From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: Arch specific mmap attributes (Was: mprotect pgprot handling weirdness)
Date: Tue, 06 Apr 2010 17:30:44 +1000 [thread overview]
Message-ID: <1270539044.13812.65.camel@pasglop> (raw)
In-Reply-To: <20100406151751.7E4E.A69D9226@jp.fujitsu.com>
On Tue, 2010-04-06 at 15:24 +0900, KOSAKI Motohiro wrote:
> I guess you haven't catch my intention. I didn't say we have to remove
> PROT_SAO and VM_SAO.
> I mean mmap(PROT_SAO) is ok, it's only append new flag, not change exiting
> flags meanings. I'm only against mprotect(PROT_NONE) turn off PROT_SAO
> implicitely.
>
> IOW I recommend we use three syscall
> mmap() create new mappings
> mprotect() change a protection of mapping (as a name)
> mattribute(): (or similar name)
> change an attribute of mapping (e.g. PROT_SAO or
> another arch specific flags)
>
> I'm not against changing mm/protect.c for PROT_SAO.
Ok, I see. No biggie. The main deal remains how we want to do that
inside the kernel :-) I think the less horrible options here are
to either extend vm_flags to always be 64-bit, or add a separate
vm_map_attributes flag, and add the necessary bits and pieces to
prevent merge accross different attribute vma's.
The more I try to hack it into vm_page_prot, the more I hate that
option.
Cheers
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arch@vger.kernel.org
Subject: Re: Arch specific mmap attributes (Was: mprotect pgprot handling weirdness)
Date: Tue, 06 Apr 2010 17:30:44 +1000 [thread overview]
Message-ID: <1270539044.13812.65.camel@pasglop> (raw)
In-Reply-To: <20100406151751.7E4E.A69D9226@jp.fujitsu.com>
On Tue, 2010-04-06 at 15:24 +0900, KOSAKI Motohiro wrote:
> I guess you haven't catch my intention. I didn't say we have to remove
> PROT_SAO and VM_SAO.
> I mean mmap(PROT_SAO) is ok, it's only append new flag, not change exiting
> flags meanings. I'm only against mprotect(PROT_NONE) turn off PROT_SAO
> implicitely.
>
> IOW I recommend we use three syscall
> mmap() create new mappings
> mprotect() change a protection of mapping (as a name)
> mattribute(): (or similar name)
> change an attribute of mapping (e.g. PROT_SAO or
> another arch specific flags)
>
> I'm not against changing mm/protect.c for PROT_SAO.
Ok, I see. No biggie. The main deal remains how we want to do that
inside the kernel :-) I think the less horrible options here are
to either extend vm_flags to always be 64-bit, or add a separate
vm_map_attributes flag, and add the necessary bits and pieces to
prevent merge accross different attribute vma's.
The more I try to hack it into vm_page_prot, the more I hate that
option.
Cheers
Ben.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-06 7:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 5:09 mprotect pgprot handling weirdness Benjamin Herrenschmidt
2010-04-06 5:09 ` Benjamin Herrenschmidt
2010-04-06 5:32 ` Benjamin Herrenschmidt
2010-04-06 5:32 ` Benjamin Herrenschmidt
2010-04-06 5:43 ` Benjamin Herrenschmidt
2010-04-06 5:43 ` Benjamin Herrenschmidt
2010-04-06 5:52 ` KOSAKI Motohiro
2010-04-06 5:52 ` KOSAKI Motohiro
2010-04-06 6:07 ` Arch specific mmap attributes (Was: mprotect pgprot handling weirdness) Benjamin Herrenschmidt
2010-04-06 6:07 ` Benjamin Herrenschmidt
2010-04-06 6:24 ` KOSAKI Motohiro
2010-04-06 6:24 ` KOSAKI Motohiro
2010-04-06 7:30 ` Benjamin Herrenschmidt [this message]
2010-04-06 7:30 ` Benjamin Herrenschmidt
2010-04-06 10:26 ` KOSAKI Motohiro
2010-04-06 10:26 ` KOSAKI Motohiro
2010-04-06 22:15 ` Benjamin Herrenschmidt
2010-04-06 22:15 ` Benjamin Herrenschmidt
2010-04-07 6:03 ` KOSAKI Motohiro
2010-04-07 6:03 ` KOSAKI Motohiro
2010-04-07 7:03 ` Arch specific mmap attributes David Miller
2010-04-07 7:03 ` David Miller
2010-04-07 7:14 ` KOSAKI Motohiro
2010-04-07 7:14 ` KOSAKI Motohiro
2010-04-07 7:18 ` David Miller
2010-04-07 7:18 ` David Miller
2010-04-07 9:00 ` Benjamin Herrenschmidt
2010-04-07 9:00 ` Benjamin Herrenschmidt
2010-04-07 8:58 ` Benjamin Herrenschmidt
2010-04-07 8:58 ` Benjamin Herrenschmidt
2010-04-07 8:56 ` Arch specific mmap attributes (Was: mprotect pgprot handling weirdness) Benjamin Herrenschmidt
2010-04-07 8:56 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270539044.13812.65.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.