All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: fweisbec@gmail.com, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu, acme@redhat.com,
	paulus@samba.org
Subject: Re: [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI
Date: Tue, 06 Apr 2010 11:20:19 +0000	[thread overview]
Message-ID: <1270552819.1595.63.camel@laptop> (raw)
In-Reply-To: <20100406.041342.183031470.davem@davemloft.net>

On Tue, 2010-04-06 at 04:13 -0700, David Miller wrote:
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Tue, 06 Apr 2010 13:12:01 +0200
> 
> > One thing we can do is make the code WARN about this, how about
> > something like the below
> 
> It's going to warn every bootup in cpu_clock() on x86.

*sigh*, yes, we could hack around that I suppose.. it would be nice to
automate this check though, I bet you don't fancy tracking down more
such splats than you have to.

You could of course insert the debug code into your arch routines but
that would limit the coverage checks to whatever you happen to run.


WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: fweisbec@gmail.com, sparclinux@vger.kernel.org,
	linux-kernel@vger.kernel.org, mingo@elte.hu, acme@redhat.com,
	paulus@samba.org
Subject: Re: [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context
Date: Tue, 06 Apr 2010 13:20:19 +0200	[thread overview]
Message-ID: <1270552819.1595.63.camel@laptop> (raw)
In-Reply-To: <20100406.041342.183031470.davem@davemloft.net>

On Tue, 2010-04-06 at 04:13 -0700, David Miller wrote:
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Tue, 06 Apr 2010 13:12:01 +0200
> 
> > One thing we can do is make the code WARN about this, how about
> > something like the below
> 
> It's going to warn every bootup in cpu_clock() on x86.

*sigh*, yes, we could hack around that I suppose.. it would be nice to
automate this check though, I bet you don't fancy tracking down more
such splats than you have to.

You could of course insert the debug code into your arch routines but
that would limit the coverage checks to whatever you happen to run.


  reply	other threads:[~2010-04-06 11:20 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-04 12:18 Random scheduler/unaligned accesses crashes with perf lock events Frederic Weisbecker
2010-04-04 12:18 ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-04 12:21 ` Random scheduler/unaligned accesses crashes with perf lock Frederic Weisbecker
2010-04-04 12:21   ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-05  1:00   ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-05  1:00     ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-05  6:57     ` Random scheduler/unaligned accesses crashes with perf lock Frederic Weisbecker
2010-04-05  6:57       ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-05 19:22       ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-05 19:22         ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-05 19:40         ` Random scheduler/unaligned accesses crashes with perf lock Frederic Weisbecker
2010-04-05 19:40           ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-05 20:46           ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-05 20:46             ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06  2:15           ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-06  2:15             ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06 13:41             ` Random scheduler/unaligned accesses crashes with perf lock Steven Rostedt
2010-04-06 13:41               ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Steven Rostedt
2010-04-06 17:46               ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-06 17:46                 ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06 18:15                 ` Random scheduler/unaligned accesses crashes with perf lock Steven Rostedt
2010-04-06 18:15                   ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Steven Rostedt
2010-04-06 21:17                   ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-06 21:17                     ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06  9:50           ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-06  9:50             ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06 10:19             ` Random scheduler/unaligned accesses crashes with perf lock Frederic Weisbecker
2010-04-06 10:19               ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-06 10:28               ` Random scheduler/unaligned accesses crashes with perf lock David Miller
2010-04-06 10:28                 ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 David Miller
2010-04-06 11:12             ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI Peter Zijlstra
2010-04-06 11:12               ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context Peter Zijlstra
2010-04-06 11:13               ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI David Miller
2010-04-06 11:13                 ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context David Miller
2010-04-06 11:20                 ` Peter Zijlstra [this message]
2010-04-06 11:20                   ` Peter Zijlstra
2010-04-06 11:22                   ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI David Miller
2010-04-06 11:22                     ` [RFC][PATCH] lockdep: WARN about local_irq_{en,dis}able in NMI context David Miller
2010-04-06 11:38             ` Random scheduler/unaligned accesses crashes with perf lock Frederic Weisbecker
2010-04-06 11:38               ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Frederic Weisbecker
2010-04-06 11:51               ` Random scheduler/unaligned accesses crashes with perf lock Peter Zijlstra
2010-04-06 11:51                 ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Peter Zijlstra
2010-04-06 12:54                 ` Random scheduler/unaligned accesses crashes with perf lock Mike Galbraith
2010-04-06 12:54                   ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Mike Galbraith
2010-04-06 12:57                   ` Random scheduler/unaligned accesses crashes with perf lock Peter Zijlstra
2010-04-06 12:57                     ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Peter Zijlstra
2010-04-06 18:04             ` Random scheduler/unaligned accesses crashes with perf lock Paul E. McKenney
2010-04-06 18:04               ` Random scheduler/unaligned accesses crashes with perf lock events on sparc 64 Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270552819.1595.63.camel@laptop \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.