From: Pavel Roskin <proski@gnu.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH v2] crypto: add blkcipher implementation of ARC4
Date: Wed, 07 Apr 2010 02:19:55 -0400 [thread overview]
Message-ID: <1270621195.31184.45.camel@mj> (raw)
In-Reply-To: <20100405170406.GA24215@Chamillionaire.breakpoint.cc>
On Mon, 2010-04-05 at 19:04 +0200, Sebastian Andrzej Siewior wrote:
> +module_init(arc4_init);
> +module_exit(arc4_exit);
I'm feelings uneasy about using the same module init/exit functions
names in arc4blk.c and arc4cip.c.
Even though it doesn't break for me on x86_64 (whether I'm compiling
modules or a solid kernel), and even though the potential name conflict
is temporary until arc4cip.c is removed, it could break on some other
architecture or maybe with another linker.
Let's use arc4blk_init and arc4blk_exit.
--
Regards,
Pavel Roskin
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Roskin <proski@gnu.org>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-crypto@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-ppp@vger.kernel.org
Subject: Re: [PATCH v2] crypto: add blkcipher implementation of ARC4
Date: Wed, 07 Apr 2010 06:19:55 +0000 [thread overview]
Message-ID: <1270621195.31184.45.camel@mj> (raw)
In-Reply-To: <20100405170406.GA24215@Chamillionaire.breakpoint.cc>
On Mon, 2010-04-05 at 19:04 +0200, Sebastian Andrzej Siewior wrote:
> +module_init(arc4_init);
> +module_exit(arc4_exit);
I'm feelings uneasy about using the same module init/exit functions
names in arc4blk.c and arc4cip.c.
Even though it doesn't break for me on x86_64 (whether I'm compiling
modules or a solid kernel), and even though the potential name conflict
is temporary until arc4cip.c is removed, it could break on some other
architecture or maybe with another linker.
Let's use arc4blk_init and arc4blk_exit.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-04-07 6:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 7:49 Convert arc4 from a cipher into a block cipher Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 1/7] crypto: rename arc4 Sebastian Andrzej Siewior
2010-04-03 7:49 ` Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 3/7] crypto/testmgr: add testing for arc4 based on ecb(arc4) Sebastian Andrzej Siewior
2010-04-07 6:29 ` Pavel Roskin
2010-04-07 9:29 ` Herbert Xu
[not found] ` <20100407092907.GB29993-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2010-04-08 7:58 ` Sebastian Andrzej Siewior
2010-04-08 7:58 ` Sebastian Andrzej Siewior
2010-04-03 7:49 ` [PATCH 4/7] net/wireless: switch lib80211_crypt_tkip from arc4 to arc4blk Sebastian Andrzej Siewior
[not found] ` <1270280969-11357-5-git-send-email-sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2010-04-05 17:13 ` John W. Linville
2010-04-05 17:13 ` John W. Linville
2010-04-03 7:49 ` [PATCH 5/7] net/wireless: switch lib80211_crypt_wep " Sebastian Andrzej Siewior
2010-04-05 17:13 ` John W. Linville
2010-04-03 7:49 ` [PATCH 6/7] net/mac80211: convert wep " Sebastian Andrzej Siewior
2010-04-05 17:15 ` John W. Linville
2010-04-03 7:49 ` [PATCH 7/7] net/ppp_mppe: convert " Sebastian Andrzej Siewior
2010-04-03 7:49 ` Sebastian Andrzej Siewior
[not found] ` <1270280969-11357-1-git-send-email-sebastian-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2010-04-03 7:49 ` [PATCH 2/7] crypto: add blkcipher implementation of ARC4 Sebastian Andrzej Siewior
2010-04-03 7:49 ` Sebastian Andrzej Siewior
2010-04-03 7:49 ` Sebastian Andrzej Siewior
2010-04-05 8:42 ` Herbert Xu
2010-04-05 8:42 ` Herbert Xu
2010-04-05 17:04 ` [PATCH v2] " Sebastian Andrzej Siewior
2010-04-05 17:04 ` Sebastian Andrzej Siewior
2010-04-06 12:44 ` Herbert Xu
2010-04-06 12:44 ` Herbert Xu
2010-04-06 20:30 ` Sebastian Andrzej Siewior
2010-04-06 20:30 ` Sebastian Andrzej Siewior
2010-04-07 0:31 ` Herbert Xu
2010-04-07 0:31 ` Herbert Xu
2010-04-07 8:23 ` Sebastian Andrzej Siewior
2010-04-07 8:23 ` Sebastian Andrzej Siewior
2010-04-07 9:25 ` Herbert Xu
2010-04-07 9:25 ` Herbert Xu
2010-04-07 6:19 ` Pavel Roskin [this message]
2010-04-07 6:19 ` Pavel Roskin
2010-04-07 8:29 ` Sebastian Andrzej Siewior
2010-04-07 8:29 ` Sebastian Andrzej Siewior
2010-04-07 16:31 ` Pavel Roskin
2010-04-07 16:31 ` Pavel Roskin
2010-04-05 20:33 ` Convert arc4 from a cipher into a block cipher Pavel Roskin
2010-04-05 20:33 ` Pavel Roskin
2010-04-06 0:39 ` Herbert Xu
2010-04-06 0:39 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270621195.31184.45.camel@mj \
--to=proski@gnu.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.