Re: [PATCH 5/5] arm: msm: smd: fix SMD modem processor sync condition

[Daniel Walker <dwalker@codeaurora.org>]

On Mon, 2010-04-19 at 11:34 -0700, Dima Zavin wrote:
> Do we really need a formalized blocking point here? The apps processor
> can do other useful initialization work while the modem is booting.
> The first time you do a proc_comm call, it checks the PCOM_READY
> state, and will block anyway. Preventing the apps processor from
> continuing until then is suboptimal. If there are bugs in the modem
> code where it incorrectly stomps on shared resources, then those
> should be fixed. This patch looks like a hack to me.


Yes, we need to formalize a blocking point .. The apps processor waits
in this way no matter what you do .. Like your saying above "The first
time you do a proc_comm call, it checks the PCOM_READY state, and will
block anyway" that's a hack .. What your saying is _maybe_ there exists
a proc_comm call early enough to prevent a crash, or maybe not .. That's
not formal enough.

This patch makes this a formal process with a comment explain what is
happening, and we will never see a crash related to this again.

Daniel