From: Artem Bityutskiy <dedekind1@gmail.com>
To: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Cc: Nicolas Pitre <nico@fluxnic.net>,
jamie@shareable.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de,
simon.kagstrom@netinsight.net, akpm@linux-foundation.org,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI
Date: Fri, 23 Apr 2010 14:56:18 +0300 [thread overview]
Message-ID: <1272023778.6917.6.camel@localhost> (raw)
In-Reply-To: <4BB33988.9070608@gmail.com>
On Wed, 2010-03-31 at 15:01 +0300, Paulius Zaleckas wrote:
> On 03/25/2010 06:26 PM, Nicolas Pitre wrote:
> > On Thu, 25 Mar 2010, Paulius Zaleckas wrote:
> >
> >> We must tell GCC to use even register for variable passed
> >> to ldrd instruction. Without this patch GCC 4.2.1 puts this
> >> variable to r2/r3 on EABI and r3/r4 on OABI, so force it to
> >> r2/r3. This does not change anything when EABI and OABI
> >> compilation works OK.
> >>
> >> Without this patch and with OABI I get:
> >> CC drivers/mtd/nand/orion_nand.o
> >> /tmp/ccMkwOCs.s: Assembler messages:
> >> /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]'
> >> make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1
> >>
> >> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@gmail.com>
> >
> > Acked-by: Nicolas Pitre<nico@fluxnic.net>
>
> David,
>
> Will you take this patch?
> Or you are waiting till I will add all Cc as Jamie suggested?
Meanwhile, I've pushed your patch to my l2-mtd-2.6.git / dunno.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI
Date: Fri, 23 Apr 2010 14:56:18 +0300 [thread overview]
Message-ID: <1272023778.6917.6.camel@localhost> (raw)
In-Reply-To: <4BB33988.9070608@gmail.com>
On Wed, 2010-03-31 at 15:01 +0300, Paulius Zaleckas wrote:
> On 03/25/2010 06:26 PM, Nicolas Pitre wrote:
> > On Thu, 25 Mar 2010, Paulius Zaleckas wrote:
> >
> >> We must tell GCC to use even register for variable passed
> >> to ldrd instruction. Without this patch GCC 4.2.1 puts this
> >> variable to r2/r3 on EABI and r3/r4 on OABI, so force it to
> >> r2/r3. This does not change anything when EABI and OABI
> >> compilation works OK.
> >>
> >> Without this patch and with OABI I get:
> >> CC drivers/mtd/nand/orion_nand.o
> >> /tmp/ccMkwOCs.s: Assembler messages:
> >> /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]'
> >> make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1
> >>
> >> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@gmail.com>
> >
> > Acked-by: Nicolas Pitre<nico@fluxnic.net>
>
> David,
>
> Will you take this patch?
> Or you are waiting till I will add all Cc as Jamie suggested?
Meanwhile, I've pushed your patch to my l2-mtd-2.6.git / dunno.
--
Best Regards,
Artem Bityutskiy (????? ????????)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Paulius Zaleckas <paulius.zaleckas@gmail.com>
Cc: dwmw2@infradead.org, Nicolas Pitre <nico@fluxnic.net>,
jamie@shareable.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, u.kleine-koenig@pengutronix.de,
simon.kagstrom@netinsight.net, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI
Date: Fri, 23 Apr 2010 14:56:18 +0300 [thread overview]
Message-ID: <1272023778.6917.6.camel@localhost> (raw)
In-Reply-To: <4BB33988.9070608@gmail.com>
On Wed, 2010-03-31 at 15:01 +0300, Paulius Zaleckas wrote:
> On 03/25/2010 06:26 PM, Nicolas Pitre wrote:
> > On Thu, 25 Mar 2010, Paulius Zaleckas wrote:
> >
> >> We must tell GCC to use even register for variable passed
> >> to ldrd instruction. Without this patch GCC 4.2.1 puts this
> >> variable to r2/r3 on EABI and r3/r4 on OABI, so force it to
> >> r2/r3. This does not change anything when EABI and OABI
> >> compilation works OK.
> >>
> >> Without this patch and with OABI I get:
> >> CC drivers/mtd/nand/orion_nand.o
> >> /tmp/ccMkwOCs.s: Assembler messages:
> >> /tmp/ccMkwOCs.s:63: Error: first destination register must be even -- `ldrd r3,[ip]'
> >> make[5]: *** [drivers/mtd/nand/orion_nand.o] Error 1
> >>
> >> Signed-off-by: Paulius Zaleckas<paulius.zaleckas@gmail.com>
> >
> > Acked-by: Nicolas Pitre<nico@fluxnic.net>
>
> David,
>
> Will you take this patch?
> Or you are waiting till I will add all Cc as Jamie suggested?
Meanwhile, I've pushed your patch to my l2-mtd-2.6.git / dunno.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-04-23 11:56 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 15:25 [PATCH v2] MTD: Fix Orion NAND driver compilation with ARM OABI Paulius Zaleckas
2010-03-25 15:25 ` Paulius Zaleckas
2010-03-25 15:25 ` Paulius Zaleckas
2010-03-25 16:26 ` Nicolas Pitre
2010-03-25 16:26 ` Nicolas Pitre
2010-03-25 16:26 ` Nicolas Pitre
2010-03-31 12:01 ` Paulius Zaleckas
2010-03-31 12:01 ` Paulius Zaleckas
2010-03-31 12:01 ` Paulius Zaleckas
2010-04-23 11:56 ` Artem Bityutskiy [this message]
2010-04-23 11:56 ` Artem Bityutskiy
2010-04-23 11:56 ` Artem Bityutskiy
2010-04-23 12:54 ` Nicolas Pitre
2010-04-23 12:54 ` Nicolas Pitre
2010-04-23 12:54 ` Nicolas Pitre
2010-04-23 15:13 ` Artem Bityutskiy
2010-04-23 15:13 ` Artem Bityutskiy
2010-04-23 15:13 ` Artem Bityutskiy
2010-04-23 17:50 ` Nicolas Pitre
2010-04-23 17:50 ` Nicolas Pitre
2010-04-23 17:50 ` Nicolas Pitre
2010-04-23 18:00 ` Andrew Morton
2010-04-23 18:00 ` Andrew Morton
2010-04-23 18:00 ` Andrew Morton
2010-04-23 18:22 ` Nicolas Pitre
2010-04-23 18:22 ` Nicolas Pitre
2010-04-23 18:22 ` Nicolas Pitre
2010-03-25 20:46 ` Jamie Lokier
2010-03-25 20:46 ` Jamie Lokier
2010-03-25 20:46 ` Jamie Lokier
2010-04-23 19:06 ` Nicolas Pitre
2010-04-23 19:06 ` Nicolas Pitre
2010-04-23 19:06 ` Nicolas Pitre
2010-04-24 2:58 ` Jamie Lokier
2010-04-24 2:58 ` Jamie Lokier
2010-04-24 2:58 ` Jamie Lokier
2010-04-24 3:04 ` Jamie Lokier
2010-04-24 3:04 ` Jamie Lokier
2010-04-24 13:02 ` Nicolas Pitre
2010-04-24 13:02 ` Nicolas Pitre
2010-04-24 13:02 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272023778.6917.6.camel@localhost \
--to=dedekind1@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=jamie@shareable.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nico@fluxnic.net \
--cc=paulius.zaleckas@gmail.com \
--cc=simon.kagstrom@netinsight.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.