* Re: [LTP] [PATCH] clone05: signal parent when the child terminates
[not found] <1355280102-13331-1-git-send-email-gaowanlong@cn.fujitsu.com>
@ 2012-12-12 9:40 ` Jan Stancek
2012-12-12 9:55 ` Wanlong Gao
2012-12-12 10:01 ` chrubis
1 sibling, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2012-12-12 9:40 UTC (permalink / raw)
To: Wanlong Gao; +Cc: LTP
----- Original Message -----
> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
> To: "LTP" <ltp-list@lists.sourceforge.net>
> Sent: Wednesday, 12 December, 2012 3:41:42 AM
> Subject: [LTP] [PATCH] clone05: signal parent when the child terminates
>
> Add SIGCHLD flag when doing clone to signal parent when the child
> terminates.
> This flag is missed by commit c91af2ff.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> testcases/kernel/syscalls/clone/clone05.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/clone/clone05.c
> b/testcases/kernel/syscalls/clone/clone05.c
> index 4797b46..06b84ed 100644
> --- a/testcases/kernel/syscalls/clone/clone05.c
> +++ b/testcases/kernel/syscalls/clone/clone05.c
> @@ -60,7 +60,7 @@ int main(int ac, char **av)
> for (lc = 0; TEST_LOOPING(lc); lc++) {
> Tst_count = 0;
>
> - TEST(ltp_clone(CLONE_VM | CLONE_VFORK, child_fn, NULL,
> + TEST(ltp_clone(CLONE_VM | CLONE_VFORK | SIGCHLD, child_fn, NULL,
Good catch.
Reviewed-by: Jan Stancek <jstancek@redhat.com>
Regards,
Jan
> CHILD_STACK_SIZE, child_stack));
>
> if ((TEST_RETURN != -1) && (child_exited))
> --
> 1.8.0
>
>
> ------------------------------------------------------------------------------
> LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
> Remotely access PCs and mobile devices and provide instant support
> Improve your efficiency, and focus on delivering more value-add
> services
> Discover what IT Professionals Know. Rescue delivers
> http://p.sf.net/sfu/logmein_12329d2d
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] clone05: signal parent when the child terminates
2012-12-12 9:40 ` [LTP] [PATCH] clone05: signal parent when the child terminates Jan Stancek
@ 2012-12-12 9:55 ` Wanlong Gao
0 siblings, 0 replies; 3+ messages in thread
From: Wanlong Gao @ 2012-12-12 9:55 UTC (permalink / raw)
To: Jan Stancek; +Cc: LTP
On 12/12/2012 05:40 PM, Jan Stancek wrote:
>
>
> ----- Original Message -----
>> From: "Wanlong Gao" <gaowanlong@cn.fujitsu.com>
>> To: "LTP" <ltp-list@lists.sourceforge.net>
>> Sent: Wednesday, 12 December, 2012 3:41:42 AM
>> Subject: [LTP] [PATCH] clone05: signal parent when the child terminates
>>
>> Add SIGCHLD flag when doing clone to signal parent when the child
>> terminates.
>> This flag is missed by commit c91af2ff.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> ---
>> testcases/kernel/syscalls/clone/clone05.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/testcases/kernel/syscalls/clone/clone05.c
>> b/testcases/kernel/syscalls/clone/clone05.c
>> index 4797b46..06b84ed 100644
>> --- a/testcases/kernel/syscalls/clone/clone05.c
>> +++ b/testcases/kernel/syscalls/clone/clone05.c
>> @@ -60,7 +60,7 @@ int main(int ac, char **av)
>> for (lc = 0; TEST_LOOPING(lc); lc++) {
>> Tst_count = 0;
>>
>> - TEST(ltp_clone(CLONE_VM | CLONE_VFORK, child_fn, NULL,
>> + TEST(ltp_clone(CLONE_VM | CLONE_VFORK | SIGCHLD, child_fn, NULL,
>
> Good catch.
> Reviewed-by: Jan Stancek <jstancek@redhat.com>
Thank you for review, committed.
Wanlong Gao
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] clone05: signal parent when the child terminates
[not found] <1355280102-13331-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-12-12 9:40 ` [LTP] [PATCH] clone05: signal parent when the child terminates Jan Stancek
@ 2012-12-12 10:01 ` chrubis
1 sibling, 0 replies; 3+ messages in thread
From: chrubis @ 2012-12-12 10:01 UTC (permalink / raw)
To: Wanlong Gao; +Cc: LTP
Hi!
> Add SIGCHLD flag when doing clone to signal parent when the child
> terminates.
> This flag is missed by commit c91af2ff.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> testcases/kernel/syscalls/clone/clone05.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/clone/clone05.c b/testcases/kernel/syscalls/clone/clone05.c
> index 4797b46..06b84ed 100644
> --- a/testcases/kernel/syscalls/clone/clone05.c
> +++ b/testcases/kernel/syscalls/clone/clone05.c
> @@ -60,7 +60,7 @@ int main(int ac, char **av)
> for (lc = 0; TEST_LOOPING(lc); lc++) {
> Tst_count = 0;
>
> - TEST(ltp_clone(CLONE_VM | CLONE_VFORK, child_fn, NULL,
> + TEST(ltp_clone(CLONE_VM | CLONE_VFORK | SIGCHLD, child_fn, NULL,
> CHILD_STACK_SIZE, child_stack));
>
> if ((TEST_RETURN != -1) && (child_exited))
Sorry, I've missed that in the merge commit (I was a bit sleepy at the
end of the day, should have postponed the merge till today).
Thanks for the fix.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-12 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1355280102-13331-1-git-send-email-gaowanlong@cn.fujitsu.com>
2012-12-12 9:40 ` [LTP] [PATCH] clone05: signal parent when the child terminates Jan Stancek
2012-12-12 9:55 ` Wanlong Gao
2012-12-12 10:01 ` chrubis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.