Re: [PATCH] Fix mute key on older Thinkpads by OSI blacklisting them

[Jerone Young <jerone.young@canonical.com>]

On Sun, 2010-04-25 at 19:44 +0100, Matthew Garrett wrote:
> On Sun, Apr 25, 2010 at 01:28:11PM -0500, Jerone Young wrote:
> 
> > I think it's not really possible to get it correct with thinkpad-acpi .
> > The reason is the userspace sound server. In our case it's pulse audio.
> > So we are no longer just dealing with ALSA anymore. So if the OS gets a
> > proper hotkey event it is able to mute at the pulse audio level then,
> > pulse audio does work at the ALSA level (toggling the mixer).
> > thinkpad-acpi has no way to check on the status of pulse audio.
> 
> This really isn't a problem. We have a mixer device for the Thinkpad's 
> own mixer, and we can send ALSA events to indicate that its state has 
> changed.

I think it is. Since pulse audio only pay attention to the Master mixer
of the primary card. The Thinkpad EC shows up basically as a second
audio card. 

But again new Thinkpads don't need this. Since they send a soft keypress
by default. So userspace catches it and changes the Master mixer to
mute.

I think all this work isn't going to help the situation any. There
appears to be a easy solution. Just a matter of getting the LEDs on some
to light correctly, and see when the hardware mute is enabled.

				Thanks,
					Jerone

>