All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: ZhangJieJing <kzjeef@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] ubifs: add update vfs super block infomation when remount to  ro mode
Date: Wed, 28 Apr 2010 10:24:13 +0300	[thread overview]
Message-ID: <1272439453.7750.20.camel@localhost> (raw)
In-Reply-To: <i2ncf7b913c1004152036t3b23af53h339b16092ecdd812@mail.gmail.com>

On Fri, 2010-04-16 at 11:36 +0800, ZhangJieJing wrote:
> If some read/write error happens(eg.CRC error), ubifs make self a read
> only mode,
> but the vfs infomation still not update.
> This patch add this also make /proc/mounts update.
> 
> Signed-off-by: Zhang Jiejing <kzjeef@gmail.com>
> ---
>  fs/ubifs/io.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c
> index 0168271..d33c233 100644
> --- a/fs/ubifs/io.c
> +++ b/fs/ubifs/io.c
> @@ -63,6 +63,7 @@ void ubifs_ro_mode(struct ubifs_info *c, int err)
>        if (!c->ro_media) {
>                c->ro_media = 1;
>                c->no_chk_data_crc = 0;
> +              c->vfs_sb->s_flags |= MS_RDONLY;
>                ubifs_warn("switched to read-only mode, error %d", err);
>                dbg_dump_stack();
>        }
> --
> 1.6.3.3

Your patch is not applicable. Try to save your own e-mail and apply the
patch with 'git am'.

Applying: UBIFS: mark VFS SB RO too
fatal: corrupt patch at line 9
Patch failed at 0001 UBIFS: mark VFS SB RO too
When you have resolved this problem run "git am -i --resolved".
If you would prefer to skip this patch, instead run "git am -i --skip".
To restore the original branch and stop patching run "git am -i
--abort".
[dedekind@sauron ubifs-2.6]\$ patch -p1 < .git/rebase-apply/patch 
patching file fs/ubifs/io.c
patch: **** malformed patch at line 9: �� � � if (!c->ro_media) {


But I've fixed this up and applied manually. It is now in the
ubifs-2.6.git tree, thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: ZhangJieJing <kzjeef@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ubifs: add update vfs super block infomation when remount to  ro mode
Date: Wed, 28 Apr 2010 10:24:13 +0300	[thread overview]
Message-ID: <1272439453.7750.20.camel@localhost> (raw)
In-Reply-To: <i2ncf7b913c1004152036t3b23af53h339b16092ecdd812@mail.gmail.com>

On Fri, 2010-04-16 at 11:36 +0800, ZhangJieJing wrote:
> If some read/write error happens(eg.CRC error), ubifs make self a read
> only mode,
> but the vfs infomation still not update.
> This patch add this also make /proc/mounts update.
> 
> Signed-off-by: Zhang Jiejing <kzjeef@gmail.com>
> ---
>  fs/ubifs/io.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> diff --git a/fs/ubifs/io.c b/fs/ubifs/io.c
> index 0168271..d33c233 100644
> --- a/fs/ubifs/io.c
> +++ b/fs/ubifs/io.c
> @@ -63,6 +63,7 @@ void ubifs_ro_mode(struct ubifs_info *c, int err)
>        if (!c->ro_media) {
>                c->ro_media = 1;
>                c->no_chk_data_crc = 0;
> +              c->vfs_sb->s_flags |= MS_RDONLY;
>                ubifs_warn("switched to read-only mode, error %d", err);
>                dbg_dump_stack();
>        }
> --
> 1.6.3.3

Your patch is not applicable. Try to save your own e-mail and apply the
patch with 'git am'.

Applying: UBIFS: mark VFS SB RO too
fatal: corrupt patch at line 9
Patch failed at 0001 UBIFS: mark VFS SB RO too
When you have resolved this problem run "git am -i --resolved".
If you would prefer to skip this patch, instead run "git am -i --skip".
To restore the original branch and stop patching run "git am -i
--abort".
[dedekind@sauron ubifs-2.6]\$ patch -p1 < .git/rebase-apply/patch 
patching file fs/ubifs/io.c
patch: **** malformed patch at line 9: �� � � if (!c->ro_media) {


But I've fixed this up and applied manually. It is now in the
ubifs-2.6.git tree, thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-04-28  7:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-16  3:36 [PATCH] ubifs: add update vfs super block infomation when remount to ro mode ZhangJieJing
2010-04-16  3:36 ` ZhangJieJing
2010-04-16 19:10 ` Artem Bityutskiy
2010-04-16 19:10   ` Artem Bityutskiy
2010-04-28  7:24 ` Artem Bityutskiy [this message]
2010-04-28  7:24   ` Artem Bityutskiy
2010-04-29  2:14   ` Zhang JieJing
2010-04-29  2:14     ` Zhang JieJing
2010-04-29  3:46     ` Artem Bityutskiy
2010-04-29  3:46       ` Artem Bityutskiy
2010-04-29  6:36       ` Zhang JieJing
2010-04-29  6:36         ` Zhang JieJing
2010-04-29  6:44         ` Artem Bityutskiy
2010-04-29  6:44           ` Artem Bityutskiy
2010-04-29  6:38       ` Zhang JieJing
2010-04-29  6:38         ` Zhang JieJing
  -- strict thread matches above, loose matches on Subject: below --
2010-04-08  7:00 [PATCH] [ubifs] " ZhangJieJing
2010-04-08  7:13 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1272439453.7750.20.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=kzjeef@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.