From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Rik van Riel <riel@redhat.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
Mel Gorman <mel@csn.ul.ie>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH 1/2] mm: Take all anon_vma locks in anon_vma_lock
Date: Mon, 03 May 2010 19:11:19 +0200 [thread overview]
Message-ID: <1272906679.1642.152.camel@laptop> (raw)
In-Reply-To: <20100503170230.GF19891@random.random>
On Mon, 2010-05-03 at 19:02 +0200, Andrea Arcangeli wrote:
> On Mon, May 03, 2010 at 06:55:12PM +0200, Peter Zijlstra wrote:
> > This does leave me worrying about concurrent faults poking at
> > vma->vm_end without synchronization.
>
> I didn't check this patch in detail yet. I agree it can be removed and
> I think it can be safely replaced with the page_table_lock.
Sure, it could probably be replaced with the ptl, but a single
anon_vma->lock would I think be better since there's more of them.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Rik van Riel <riel@redhat.com>,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
Mel Gorman <mel@csn.ul.ie>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Christoph Lameter <cl@linux.com>
Subject: Re: [PATCH 1/2] mm: Take all anon_vma locks in anon_vma_lock
Date: Mon, 03 May 2010 19:11:19 +0200 [thread overview]
Message-ID: <1272906679.1642.152.camel@laptop> (raw)
In-Reply-To: <20100503170230.GF19891@random.random>
On Mon, 2010-05-03 at 19:02 +0200, Andrea Arcangeli wrote:
> On Mon, May 03, 2010 at 06:55:12PM +0200, Peter Zijlstra wrote:
> > This does leave me worrying about concurrent faults poking at
> > vma->vm_end without synchronization.
>
> I didn't check this patch in detail yet. I agree it can be removed and
> I think it can be safely replaced with the page_table_lock.
Sure, it could probably be replaced with the ptl, but a single
anon_vma->lock would I think be better since there's more of them.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-03 17:11 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 16:17 [PATCH 0/2] Fix migration races in rmap_walk() V4 Rik van Riel
2010-05-03 16:17 ` Rik van Riel
2010-05-03 16:18 ` [PATCH 1/2] mm: Take all anon_vma locks in anon_vma_lock Rik van Riel
2010-05-03 16:18 ` Rik van Riel
2010-05-03 16:41 ` Linus Torvalds
2010-05-03 16:41 ` Linus Torvalds
2010-05-03 16:53 ` Rik van Riel
2010-05-03 16:53 ` Rik van Riel
2010-05-03 17:17 ` Linus Torvalds
2010-05-03 17:17 ` Linus Torvalds
2010-05-03 17:58 ` Rik van Riel
2010-05-03 17:58 ` Rik van Riel
2010-05-03 18:13 ` Andrea Arcangeli
2010-05-03 18:13 ` Andrea Arcangeli
2010-05-03 18:19 ` Linus Torvalds
2010-05-03 18:19 ` Linus Torvalds
2010-05-03 18:38 ` Rik van Riel
2010-05-03 18:38 ` Rik van Riel
2010-05-04 13:12 ` Mel Gorman
2010-05-04 13:12 ` Mel Gorman
2010-05-03 16:55 ` Peter Zijlstra
2010-05-03 16:55 ` Peter Zijlstra
2010-05-03 17:02 ` Andrea Arcangeli
2010-05-03 17:02 ` Andrea Arcangeli
2010-05-03 17:11 ` Peter Zijlstra [this message]
2010-05-03 17:11 ` Peter Zijlstra
2010-05-03 17:18 ` Andrea Arcangeli
2010-05-03 17:18 ` Andrea Arcangeli
2010-05-03 16:19 ` [PATCH 2/2] mm: fix race between shift_arg_pages and rmap_walk Rik van Riel
2010-05-03 16:19 ` Rik van Riel
2010-05-03 16:34 ` Linus Torvalds
2010-05-03 16:34 ` Linus Torvalds
2010-05-03 16:37 ` Linus Torvalds
2010-05-03 16:37 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2010-04-29 8:32 [PATCH 0/2] Fix migration races in rmap_walk() V3 Mel Gorman
2010-04-29 8:32 ` [PATCH 1/2] mm: Take all anon_vma locks in anon_vma_lock Mel Gorman
2010-04-29 8:32 ` Mel Gorman
2010-05-02 17:28 ` Minchan Kim
2010-05-02 17:28 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272906679.1642.152.camel@laptop \
--to=peterz@infradead.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.