From: Artem Bityutskiy <dedekind1@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Dmitry Pervushin <dpervushin@embeddedalley.com>,
Roel Kluin <roel.kluin@gmail.com>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH] ubi: init even if mtd device cannot be attached, if built into kernel
Date: Wed, 05 May 2010 08:14:42 +0300 [thread overview]
Message-ID: <1273036482.3702.37.camel@localhost> (raw)
In-Reply-To: <1273036359.3702.35.camel@localhost>
On Wed, 2010-05-05 at 08:12 +0300, Artem Bityutskiy wrote:
> > +#ifdef CONFIG_MTD_UBI_MODULE
> > +static inline int ubi_is_module(void) { return 1; }
> > +#else
> > +static inline int ubi_is_module(void) { return 0; }
> > +#endif
>
> I really hate these ifdefs. Dunno why, but they feel disgusting.
>
> I understand your issue and agree that is should be fixed. And I cannot
> really see a better solution. So if no-one complains, I'll accept your
> patch.
>
> However, for consistency with other UBI code (see debug.h), please, do
> this like
>
> #ifdef CONFIG_MTD_UBI_MODULE
> #define ubi_is_module() 1
> #else
> #define ubi_is_module() 1
> #endif
Err, of course the second one should be 0, not 1. I can actually do this
modification myself, or you can re-send your patch.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Kevin Cernekee <kpc.mtd@gmail.com>,
Adrian Hunter <adrian.hunter@nokia.com>,
Dmitry Pervushin <dpervushin@embeddedalley.com>,
Roel Kluin <roel.kluin@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ubi: init even if mtd device cannot be attached, if built into kernel
Date: Wed, 05 May 2010 08:14:42 +0300 [thread overview]
Message-ID: <1273036482.3702.37.camel@localhost> (raw)
In-Reply-To: <1273036359.3702.35.camel@localhost>
On Wed, 2010-05-05 at 08:12 +0300, Artem Bityutskiy wrote:
> > +#ifdef CONFIG_MTD_UBI_MODULE
> > +static inline int ubi_is_module(void) { return 1; }
> > +#else
> > +static inline int ubi_is_module(void) { return 0; }
> > +#endif
>
> I really hate these ifdefs. Dunno why, but they feel disgusting.
>
> I understand your issue and agree that is should be fixed. And I cannot
> really see a better solution. So if no-one complains, I'll accept your
> patch.
>
> However, for consistency with other UBI code (see debug.h), please, do
> this like
>
> #ifdef CONFIG_MTD_UBI_MODULE
> #define ubi_is_module() 1
> #else
> #define ubi_is_module() 1
> #endif
Err, of course the second one should be 0, not 1. I can actually do this
modification myself, or you can re-send your patch.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-05-05 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 10:41 [PATCH] ubi: init even if mtd device cannot be attached, if built into kernel Marc Kleine-Budde
2010-04-29 10:41 ` Marc Kleine-Budde
2010-05-05 5:12 ` Artem Bityutskiy
2010-05-05 5:12 ` Artem Bityutskiy
2010-05-05 5:14 ` Artem Bityutskiy [this message]
2010-05-05 5:14 ` Artem Bityutskiy
2010-05-05 7:59 ` Marc Kleine-Budde
2010-05-05 7:59 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273036482.3702.37.camel@localhost \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=dpervushin@embeddedalley.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mkl@pengutronix.de \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.