Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()

[Alex Williamson <alex.williamson@redhat.com>]

On Tue, 2010-05-11 at 21:17 +0300, Blue Swirl wrote:
> On 5/10/10, Alex Williamson <alex.williamson@redhat.com> wrote:
> >
> >   hw/pci.c |   17 ++++++++++++-----
> >   1 files changed, 12 insertions(+), 5 deletions(-)
> >
> >  diff --git a/hw/pci.c b/hw/pci.c
> >  index f167436..3d3560e 100644
> >  --- a/hw/pci.c
> >  +++ b/hw/pci.c
> >  @@ -625,6 +625,14 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
> >      return pci_dev;
> >   }
> >
> >  +static void do_pci_unregister_device(PCIDevice *pci_dev)
> >  +{
> >  +    qemu_free_irqs(pci_dev->irq);
> >  +    pci_dev->bus->devices[pci_dev->devfn] = NULL;
> >  +    pci_config_free(pci_dev);
> >  +    return;
> 
> Isn't this 'return' useless?

Yeah, I'll remove it.

Alex