From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH] pci: cleanly backout of pci_qdev_init()
Date: Tue, 11 May 2010 11:36:25 +0200 [thread overview]
Message-ID: <4BE92519.9070400@redhat.com> (raw)
In-Reply-To: <m3r5lieqo3.fsf@blackfin.pond.sub.org>
On 05/11/10 11:25, Markus Armbruster wrote:
> Alex Williamson<alex.williamson@redhat.com> writes:
>
>> If the init function of a device fails, as might happen with device
>> assignment, we never undo the work done by do_pci_register_device().
>> This not only causes a bit of a memory leak, but also leaves a bogus
>> pointer in the bus devices array that can cause a segfault or
>> garbage data from 'info pci'.
>>
>> Signed-off-by: Alex Williamson<alex.williamson@redhat.com>
>
> Looks good to me. Gerd?
Yes, looks fine.
cheers,
Gerd
next prev parent reply other threads:[~2010-05-11 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 15:00 [PATCH] pci: cleanly backout of pci_qdev_init() Alex Williamson
2010-05-10 15:00 ` [Qemu-devel] " Alex Williamson
2010-05-11 9:25 ` Markus Armbruster
2010-05-11 9:36 ` Gerd Hoffmann [this message]
2010-05-11 18:17 ` Blue Swirl
2010-05-11 18:40 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE92519.9070400@redhat.com \
--to=kraxel@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.