From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tglx@linuxtronix.de, mingo@elte.hu, davem@davemloft.net,
lethal@linux-sh.org
Subject: Re: [PATCH 05/25] lmb: Factor the lowest level alloc function
Date: Wed, 12 May 2010 08:24:09 +1000 [thread overview]
Message-ID: <1273616649.21352.44.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.1005111428470.3401@localhost.localdomain>
On Tue, 2010-05-11 at 14:30 +0200, Thomas Gleixner wrote:
> > @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64
> align, u64 max_addr)
> > if (max_addr == LMB_ALLOC_ANYWHERE)
> > max_addr = LMB_REAL_LIMIT;
> >
> > + /* Pump up max_addr */
> > + if (max_addr == LMB_ALLOC_ANYWHERE)
> > + max_addr = ~(u64)0;
> > +
>
> That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
> right above.
This is a mismerge/mis-rebase of one of my patches actually. I'll dbl
check what's up but I think the first hunk should go along with
LMB_REAL_LIMIT in favor of the new default limit thing. But we first
need to make sure the default is set sensibly and I haven't fixed all
archs yet.
I'll dbl check what's up there.
Cheers,
Benm.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tglx@linuxtronix.de, mingo@elte.hu, davem@davemloft.net,
lethal@linux-sh.org
Subject: Re: [PATCH 05/25] lmb: Factor the lowest level alloc function
Date: Wed, 12 May 2010 08:24:09 +1000 [thread overview]
Message-ID: <1273616649.21352.44.camel@pasglop> (raw)
In-Reply-To: <alpine.LFD.2.00.1005111428470.3401@localhost.localdomain>
On Tue, 2010-05-11 at 14:30 +0200, Thomas Gleixner wrote:
> > @@ -396,33 +406,24 @@ u64 __init __lmb_alloc_base(u64 size, u64
> align, u64 max_addr)
> > if (max_addr == LMB_ALLOC_ANYWHERE)
> > max_addr = LMB_REAL_LIMIT;
> >
> > + /* Pump up max_addr */
> > + if (max_addr == LMB_ALLOC_ANYWHERE)
> > + max_addr = ~(u64)0;
> > +
>
> That if is pretty useless as you set max_addr to LMB_REAL_LIMIT
> right above.
This is a mismerge/mis-rebase of one of my patches actually. I'll dbl
check what's up but I think the first hunk should go along with
LMB_REAL_LIMIT in favor of the new default limit thing. But we first
need to make sure the default is set sensibly and I haven't fixed all
archs yet.
I'll dbl check what's up there.
Cheers,
Benm.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-11 22:25 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 9:38 [PATCH/WIP] lmb cleanups and additions Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 01/25] lmb: Rename lmb_region to lmb_type and lmb_property to lmb_region Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 02/25] lmb: No reason to include asm/lmb.h late Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 03/25] lmb: Introduce for_each_lmb() and new accessors, and use it Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 04/25] lmb: Remove nid_range argument, arch provides lmb_nid_range() instead Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 05/25] lmb: Factor the lowest level alloc function Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 06/25] lmb: Expose LMB_ALLOC_ANYWHERE Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 07/25] lmb: Introduce default allocation limit and use it to replace explicit ones Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 08/25] lmb: Remove rmo_size, burry it in arch/powerpc where it belongs Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 09/25] lmb: Change u64 to phys_addr_t Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 10/25] lmb: Remove unused lmb.debug struct member Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 11/25] lmb: Remove lmb_type.size and add lmb.memory_size instead Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 12/25] lmb: Move lmb arrays to static storage in lmb.c and make their size a variable Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 13/25] lmb: Add debug markers at the end of the array Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 14/25] lmb: Make lmb_find_region() out of lmb_alloc_region() Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 15/25] lmb: Define LMB_ERROR internally instead of using ~(phys_addr_t)0 Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 16/25] lmb: Move lmb_init() to the bottom of the file Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 17/25] lmb: split lmb_find_base() out of __lmb_alloc_base() Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 18/25] lmb: Move functions around into a more sensible order Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 19/25] lmb: Add array resizing support Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 20/25] lmb: Add arch function to control coalescing of lmb memory regions Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 21/25] lmb: Add "start" argument to lmb_find_base() Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 22/25] lmb: NUMA allocate can now use early_pfn_map Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 9:38 ` [PATCH 23/25] lmb: Separate lmb_alloc_nid() and lmb_alloc_try_nid() Benjamin Herrenschmidt
2010-05-10 9:38 ` Benjamin Herrenschmidt
2010-05-10 23:37 ` [PATCH 21/25] lmb: Add "start" argument to lmb_find_base() Yinghai Lu
2010-05-10 23:37 ` Yinghai Lu
2010-05-11 4:56 ` Benjamin Herrenschmidt
2010-05-11 4:56 ` Benjamin Herrenschmidt
2010-05-10 23:59 ` [PATCH 19/25] lmb: Add array resizing support Yinghai Lu
2010-05-10 23:59 ` Yinghai Lu
2010-05-11 4:56 ` Benjamin Herrenschmidt
2010-05-11 4:56 ` Benjamin Herrenschmidt
2010-05-11 17:54 ` Yinghai Lu
2010-05-11 17:54 ` Yinghai Lu
2010-05-10 10:44 ` [PATCH 12/25] lmb: Move lmb arrays to static storage in lmb.c and make their size a variable Paul Mundt
2010-05-10 10:44 ` Paul Mundt
2010-05-10 11:46 ` Benjamin Herrenschmidt
2010-05-10 11:46 ` Benjamin Herrenschmidt
2010-05-11 12:30 ` [PATCH 05/25] lmb: Factor the lowest level alloc function Thomas Gleixner
2010-05-11 12:30 ` Thomas Gleixner
2010-05-11 22:24 ` Benjamin Herrenschmidt [this message]
2010-05-11 22:24 ` Benjamin Herrenschmidt
2010-05-12 5:24 ` Benjamin Herrenschmidt
2010-05-12 5:24 ` Benjamin Herrenschmidt
2010-05-10 15:39 ` [PATCH 03/25] lmb: Introduce for_each_lmb() and new accessors, and use it Thomas Gleixner
2010-05-10 15:39 ` Thomas Gleixner
2010-05-10 21:52 ` Benjamin Herrenschmidt
2010-05-10 21:52 ` Benjamin Herrenschmidt
2010-05-12 5:20 ` Benjamin Herrenschmidt
2010-05-12 5:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273616649.21352.44.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tglx@linuxtronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.