* [PATCH] HID: Removed unused variable from hidraw_read
@ 2010-05-19 20:41 ` Stefan Achatz
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Achatz @ 2010-05-19 20:41 UTC (permalink / raw)
To: Jiri Kosina, Stefan Achatz, iceberg, Alexey Dobriyan, Tejun Heo,
linux-i
Removed unused variable from hidraw_read.
Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
---
drivers/hid/hidraw.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 6eadf1a..bfe1e26 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
{
struct hidraw_list *list = file->private_data;
int ret = 0, len;
- char *report;
DECLARE_WAITQUEUE(wait, current);
mutex_lock(&list->read_mutex);
@@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
if (ret)
goto out;
- report = list->buffer[list->tail].value;
len = list->buffer[list->tail].len > count ?
count : list->buffer[list->tail].len;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] HID: Removed unused variable from hidraw_read
@ 2010-05-19 20:41 ` Stefan Achatz
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Achatz @ 2010-05-19 20:41 UTC (permalink / raw)
To: Jiri Kosina, Stefan Achatz, iceberg, Alexey Dobriyan, Tejun Heo,
linux-input, linux-kernel
Removed unused variable from hidraw_read.
Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
---
drivers/hid/hidraw.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 6eadf1a..bfe1e26 100644
--- a/drivers/hid/hidraw.c
+++ b/drivers/hid/hidraw.c
@@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
{
struct hidraw_list *list = file->private_data;
int ret = 0, len;
- char *report;
DECLARE_WAITQUEUE(wait, current);
mutex_lock(&list->read_mutex);
@@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
if (ret)
goto out;
- report = list->buffer[list->tail].value;
len = list->buffer[list->tail].len > count ?
count : list->buffer[list->tail].len;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: Removed unused variable from hidraw_read
2010-05-19 20:41 ` Stefan Achatz
(?)
@ 2010-05-25 7:47 ` Jiri Kosina
-1 siblings, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2010-05-25 7:47 UTC (permalink / raw)
To: Stefan Achatz
Cc: iceberg, Alexey Dobriyan, Tejun Heo, linux-input, linux-kernel
On Wed, 19 May 2010, Stefan Achatz wrote:
> Removed unused variable from hidraw_read.
>
> Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
> ---
> drivers/hid/hidraw.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
> index 6eadf1a..bfe1e26 100644
> --- a/drivers/hid/hidraw.c
> +++ b/drivers/hid/hidraw.c
> @@ -46,7 +46,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
> {
> struct hidraw_list *list = file->private_data;
> int ret = 0, len;
> - char *report;
> DECLARE_WAITQUEUE(wait, current);
>
> mutex_lock(&list->read_mutex);
> @@ -84,7 +83,6 @@ static ssize_t hidraw_read(struct file *file, char __user *buffer, size_t count,
> if (ret)
> goto out;
>
> - report = list->buffer[list->tail].value;
> len = list->buffer[list->tail].len > count ?
> count : list->buffer[list->tail].len;
>
Applied, good catch. Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-25 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19 20:41 [PATCH] HID: Removed unused variable from hidraw_read Stefan Achatz
2010-05-19 20:41 ` Stefan Achatz
2010-05-25 7:47 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.