All of lore.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Len Brown <len.brown@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: (No subject header)
Date: Thu, 27 May 2010 00:25:29 -0500	[thread overview]
Message-ID: <1274937929_9182@mail4.comsite.net> (raw)
In-Reply-To: <4a831611847e8965ed5f3328e52fe8758115b951.1274926772.git.len.brown@intel.com>


[Hmm, why did this not appear in patchwork.kernel.org?  Now
I have to guess a CC list.]

On Wed, 26 May 2010 around 22:43:50 -0400 (EDT), Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> 
> TS_POLLING set tells the scheduler a task will poll
> need_resched() to look for work.
> 

True

> TS_POLLING clear tells resched_task() and wake_up_idle_cpu()
> that the remote CPU is sleeping in idle, and thus requires
> a reschedule interrupt to wake them to notice work.

No, that only applies to the idle task.


> 
> Update the description of TS_POLLING to reflect how it works.
> "cleared when sleeping in idle, requiring reschedule interrupt"

That would imply its set for every normal task that is not in some
kind of sleep state.


> 
> Signed-off-by: Len Brown <len.brown@intel.com>
> Acked-by: Peter Zijlstra <peterz@infradead.org>

> -#define TS_POLLING		0x0004	/* true if in idle loop
> -					   and not sleeping */
> +#define TS_POLLING		0x0004	/* clear when sleeping in idle
> +					   requiring reschedule interrupt */

How about "idle task polling need_resched, skip sending interrupt"?

milton

WARNING: multiple messages have this Message-ID (diff)
From: Milton Miller <miltonm@bga.com>
To: Len Brown <len.brown@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: (No subject header)
Date: Thu, 27 May 2010 00:25:29 -0500	[thread overview]
Message-ID: <1274937929_9182@mail4.comsite.net> (raw)
In-Reply-To: <4a831611847e8965ed5f3328e52fe8758115b951.1274926772.git.len.brown@intel.com>


[Hmm, why did this not appear in patchwork.kernel.org?  Now
I have to guess a CC list.]

On Wed, 26 May 2010 around 22:43:50 -0400 (EDT), Len Brown wrote:
> From: Len Brown <len.brown@intel.com>
> 
> TS_POLLING set tells the scheduler a task will poll
> need_resched() to look for work.
> 

True

> TS_POLLING clear tells resched_task() and wake_up_idle_cpu()
> that the remote CPU is sleeping in idle, and thus requires
> a reschedule interrupt to wake them to notice work.

No, that only applies to the idle task.


> 
> Update the description of TS_POLLING to reflect how it works.
> "cleared when sleeping in idle, requiring reschedule interrupt"

That would imply its set for every normal task that is not in some
kind of sleep state.


> 
> Signed-off-by: Len Brown <len.brown@intel.com>
> Acked-by: Peter Zijlstra <peterz@infradead.org>

> -#define TS_POLLING		0x0004	/* true if in idle loop
> -					   and not sleeping */
> +#define TS_POLLING		0x0004	/* clear when sleeping in idle
> +					   requiring reschedule interrupt */

How about "idle task polling need_resched, skip sending interrupt"?

milton

  reply	other threads:[~2010-05-27  5:25 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  2:42 idle-test patches queued for upstream Len Brown
2010-05-27  2:42 ` [PATCH 1/8] cpuidle: fail to register if !CONFIG_CPU_IDLE Len Brown
2010-05-27  2:42 ` Len Brown
2010-05-27  2:42   ` [PATCH 2/8] cpuidle: add cpuidle_unregister_driver() error check Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  3:14     ` Andrew Morton
2010-05-27  3:14     ` Andrew Morton
2010-05-27  5:11       ` [PATCH-v2 " Len Brown
2010-05-27  5:13         ` Andrew Morton
2010-05-27  5:13         ` Andrew Morton
2010-05-27  5:11       ` Len Brown
2010-05-27  2:42   ` [PATCH 3/8] cpuidle: make cpuidle_curr_driver static Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  5:27     ` [PATCH-v2 " Len Brown
2010-05-27  5:27     ` Len Brown
2010-05-27 18:40       ` Luck, Tony
2010-05-27 23:30         ` Len Brown
2010-05-27 23:30         ` Len Brown
2010-05-27 18:40       ` Luck, Tony
2010-05-27  2:42   ` [PATCH 4/8] ACPI: allow a native cpuidle driver to displace ACPI Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  2:42   ` [PATCH 5/8] sched: clarify commment for TS_POLLING Len Brown
2010-05-27  5:25     ` Milton Miller [this message]
2010-05-27  5:25       ` (No subject header) Milton Miller
2010-05-27  5:47       ` Len Brown
2010-05-27  5:53     ` [PATCH-v2 5/8] sched: clarify commment for TS_POLLING Len Brown
2010-05-27  5:53     ` Len Brown
2010-05-27  2:42   ` [PATCH " Len Brown
2010-05-27  2:42   ` [PATCH 6/8] acpi_pad: uses MONITOR/MWAIT, so it doesn't need to clear TS_POLLING Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  2:42   ` [PATCH 7/8] ACPI: acpi_idle: touch TS_POLLING only in the non-MWAIT case Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  2:42   ` [PATCH 8/8] intel_idle: create a native cpuidle driver for select intel processors Len Brown
2010-05-27  2:42   ` Len Brown
2010-05-27  3:44     ` Andrew Morton
2010-05-27  3:44     ` Andrew Morton
2010-05-28  3:57       ` Len Brown
2010-05-30  9:20         ` Andi Kleen
2010-05-30  9:20         ` Andi Kleen
2010-05-28  3:57       ` Len Brown
2010-05-27  8:53     ` Thomas Renninger
2010-05-27  8:53     ` [linux-pm] " Thomas Renninger
2010-05-28  1:44       ` Len Brown
2010-05-28  7:46         ` Thomas Renninger
2010-05-28 17:38           ` Len Brown
2010-05-28 17:38             ` [linux-pm] " Len Brown
2010-05-28  7:46         ` Thomas Renninger
2010-05-29  4:17         ` [linux-pm] " Thomas Renninger
2010-05-29  4:17         ` Thomas Renninger
2010-05-28  1:44       ` Len Brown
2010-05-27 14:14     ` Kevin Hilman
2010-05-27 14:14     ` Kevin Hilman
2010-05-27 14:22       ` Arjan van de Ven
2010-05-27 14:22       ` Arjan van de Ven
2010-05-27 14:36         ` Kevin Hilman
2010-05-27 14:36         ` Kevin Hilman
2010-05-28  0:22           ` Len Brown
2010-05-28 17:28             ` Kevin Hilman
2010-05-28 17:28             ` Kevin Hilman
2010-05-28  0:22           ` Len Brown
2010-05-27 14:51         ` [linux-pm] " Igor Stoppa
2010-05-28  3:14           ` Arjan van de Ven
2010-05-28  3:14           ` [linux-pm] " Arjan van de Ven
2010-05-28 17:27             ` Kevin Hilman
2010-05-28 17:27             ` [linux-pm] " Kevin Hilman
2010-05-29  0:38               ` Arjan van de Ven
2010-05-29  0:38               ` [linux-pm] " Arjan van de Ven
2010-05-27 14:51         ` Igor Stoppa
2010-05-28  2:32     ` Chase Douglas
2010-05-28  2:32     ` Chase Douglas
2010-05-28  4:16       ` Len Brown
2010-05-28  4:16       ` Len Brown
2010-05-28 15:09         ` Chase Douglas
2010-05-28 15:09         ` Chase Douglas
2010-05-28 17:43           ` Len Brown
2010-05-28 19:51             ` Chase Douglas
2010-05-28 19:51             ` Chase Douglas
2010-05-28 20:14               ` Chase Douglas
2010-05-28 20:14               ` Chase Douglas
2010-05-28 17:43           ` Len Brown
2010-05-27  8:45 ` [linux-pm] idle-test patches queued for upstream Thomas Renninger
2010-05-28  0:59   ` Len Brown
2010-05-28  0:59   ` [linux-pm] " Len Brown
2010-05-28  8:07     ` Thomas Renninger
2010-05-28  8:07     ` [linux-pm] " Thomas Renninger
2010-05-28 17:42       ` Len Brown
2010-05-28 17:42       ` [linux-pm] " Len Brown
2010-06-16  7:53     ` Pavel Machek
2010-06-16  7:53     ` [linux-pm] " Pavel Machek
2010-05-27  8:45 ` Thomas Renninger
  -- strict thread matches above, loose matches on Subject: below --
2014-08-26 20:52 (No subject header) gina
2010-11-30 20:01 [PATCH 3/4] exec: unify compat_do_execve() code Oleg Nesterov
2010-12-01 17:37 ` (No subject header) Milton Miller
2010-12-01 17:37   ` Milton Miller
2010-12-01 18:27   ` Oleg Nesterov
2010-12-01 18:27     ` Oleg Nesterov
2010-11-09  7:27 Doubt about CRTSCTS preprocessor macro definition in termbits.h file Ramya Desai
2010-11-09 16:56 ` (No subject header) Milton Miller
2004-11-29 23:10 John Black
2004-11-29 23:00 John Black
2004-11-30  7:09 ` Brent Clark
2004-07-30  3:33 Jason Opperisano
2004-07-30  4:00 ` John Black
2004-07-28 16:01 John Black
2004-07-28 21:52 ` Antony Stone
2004-07-30  3:09   ` John Black

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1274937929_9182@mail4.comsite.net \
    --to=miltonm@bga.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.