From: Liam Girdwood <lrg@slimlogic.co.uk>
To: "Eric Bénard" <eric@eukrea.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] soc/imx: add eukrea-tlv320
Date: Thu, 27 May 2010 15:14:17 +0100 [thread overview]
Message-ID: <1274969657.3542.303.camel@odin> (raw)
In-Reply-To: <4BFE7BFF.7010400@eukrea.com>
On Thu, 2010-05-27 at 16:04 +0200, Eric Bénard wrote:
> Hi Liam,
>
> Le 27/05/2010 15:50, Liam Girdwood a écrit :
> >> +
> >> + eukrea_tlv320_dai.cpu_dai =&imx_ssi_pcm_dai[0];
> >
> > Any reason why this is not defined above ?
> >
> I plan to reuse this driver for iMX25, 35 & 51 based boards so this
> parameter may change depending on machine_is_xxx macro.
Ok, I see. You will have a machine_is_blah() statement to select the
correct DAI.
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: lrg@slimlogic.co.uk (Liam Girdwood)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH v2 2/4] soc/imx: add eukrea-tlv320
Date: Thu, 27 May 2010 15:14:17 +0100 [thread overview]
Message-ID: <1274969657.3542.303.camel@odin> (raw)
In-Reply-To: <4BFE7BFF.7010400@eukrea.com>
On Thu, 2010-05-27 at 16:04 +0200, Eric B?nard wrote:
> Hi Liam,
>
> Le 27/05/2010 15:50, Liam Girdwood a ?crit :
> >> +
> >> + eukrea_tlv320_dai.cpu_dai =&imx_ssi_pcm_dai[0];
> >
> > Any reason why this is not defined above ?
> >
> I plan to reuse this driver for iMX25, 35 & 51 based boards so this
> parameter may change depending on machine_is_xxx macro.
Ok, I see. You will have a machine_is_blah() statement to select the
correct DAI.
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-05-27 14:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 8:58 [PATCH v2 1/4] imx-ssi.c: add new choices to platform configuration Eric Bénard
2010-05-27 8:58 ` Eric Bénard
2010-05-27 8:58 ` [PATCH v2 2/4] soc/imx: add eukrea-tlv320 Eric Bénard
2010-05-27 8:58 ` Eric Bénard
2010-05-27 8:58 ` [PATCH v2 3/4] eukrea_mbimx27: add audio codec Eric Bénard
2010-05-27 8:58 ` Eric Bénard
2010-05-27 8:58 ` [PATCH v2 4/4] mx27_defconfig: add audio support for eukrea_mbimx27 Eric Bénard
2010-05-27 8:58 ` Eric Bénard
2010-05-27 13:51 ` [PATCH v2 3/4] eukrea_mbimx27: add audio codec Liam Girdwood
2010-05-27 13:51 ` Liam Girdwood
2010-05-28 6:58 ` Sascha Hauer
2010-05-28 6:58 ` Sascha Hauer
2010-05-28 9:17 ` Eric Bénard
2010-05-28 9:17 ` Eric Bénard
2010-05-27 13:50 ` [PATCH v2 2/4] soc/imx: add eukrea-tlv320 Liam Girdwood
2010-05-27 13:50 ` Liam Girdwood
2010-05-27 14:04 ` Eric Bénard
2010-05-27 14:04 ` Eric Bénard
2010-05-27 14:14 ` Liam Girdwood [this message]
2010-05-27 14:14 ` [alsa-devel] " Liam Girdwood
2010-05-27 13:49 ` [PATCH v2 1/4] imx-ssi.c: add new choices to platform configuration Liam Girdwood
2010-05-27 13:49 ` [alsa-devel] " Liam Girdwood
2010-06-01 18:05 ` Mark Brown
2010-06-01 18:05 ` [alsa-devel] " Mark Brown
2010-06-03 8:19 ` Sascha Hauer
2010-06-03 8:19 ` [alsa-devel] " Sascha Hauer
2010-06-03 16:52 ` Mark Brown
2010-06-03 16:52 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274969657.3542.303.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.