All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mips: drop CLEAN_FILES from arch/mips/Makefile
@ 2010-05-29 11:17 Sam Ravnborg
  2010-05-29 12:06 ` Wu Zhangjin
  0 siblings, 1 reply; 5+ messages in thread
From: Sam Ravnborg @ 2010-05-29 11:17 UTC (permalink / raw)
  To: Ralf Baechle, linux-mips



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] mips: drop CLEAN_FILES from arch/mips/Makefile
  2010-05-29 11:17 [PATCH] mips: drop CLEAN_FILES from arch/mips/Makefile Sam Ravnborg
@ 2010-05-29 12:06 ` Wu Zhangjin
  2010-05-29 19:40     ` Sam Ravnborg
  0 siblings, 1 reply; 5+ messages in thread
From: Wu Zhangjin @ 2010-05-29 12:06 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Ralf Baechle, linux-mips

Hi, Sam

With your patch, It really drops the specified files in the root
directory of Linux source code but can not remove the files under
arch/mips/boot/compressed/.

I have kept some temp files (.bin, .lzo...) under
arch/mips/boot/compressed/, 

> diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile
> index 790ddd3..80f6de5 100644
> --- a/arch/mips/boot/compressed/Makefile
> +++ b/arch/mips/boot/compressed/Makefile
> @@ -100,6 +100,4 @@ OBJCOPYFLAGS_vmlinuz.srec := $(OBJCOPYFLAGS) -S -O srec
>  vmlinuz.srec: vmlinuz
>  	$(call if_changed,objcopy)
>  
> -clean:
> -clean-files += *.o \
> -	       vmlinu*
> +clean-files := $(objtree)/vmlinu*

So, perhaps we need to reserve the vmlinux*, then we get

+ clean-files := vmlinu* \
                 $(objtree)/vmlinu*

Best Regards,
	Wu Zhangjin

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCHv2] mips: drop CLEAN_FILES from arch/mips/Makefile
@ 2010-05-29 19:40     ` Sam Ravnborg
  0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2010-05-29 19:40 UTC (permalink / raw)
  To: Wu Zhangjin, Ralf Baechle; +Cc: Ralf Baechle, linux-mips



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCHv2] mips: drop CLEAN_FILES from arch/mips/Makefile
@ 2010-05-29 19:40     ` Sam Ravnborg
  0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2010-05-29 19:40 UTC (permalink / raw)
  To: Wu Zhangjin, Ralf Baechle; +Cc: linux-mips



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCHv2] mips: drop CLEAN_FILES from arch/mips/Makefile
  2010-05-29 19:40     ` Sam Ravnborg
  (?)
@ 2010-05-30  3:00     ` Wu Zhangjin
  -1 siblings, 0 replies; 5+ messages in thread
From: Wu Zhangjin @ 2010-05-30  3:00 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: Ralf Baechle, linux-mips

Hi, Sam

Most of them looks good, thanks!

[...]
> diff --git a/arch/mips/boot/compressed/Makefile b/arch/mips/boot/compressed/Makefile
> index 790ddd3..223dd4d 100644
> --- a/arch/mips/boot/compressed/Makefile
> +++ b/arch/mips/boot/compressed/Makefile
> @@ -100,6 +100,7 @@ OBJCOPYFLAGS_vmlinuz.srec := $(OBJCOPYFLAGS) -S -O srec
>  vmlinuz.srec: vmlinuz
>  	$(call if_changed,objcopy)
>  
> -clean:
> -clean-files += *.o \
> -	       vmlinu*
> +# vmlinu* files created in top-level dir of the kernel
> +clean-files := $(objtree)/vmlinu*
> +# files created in arch/mips/boot/compressed
> +clean-files += vmlinux.* piggy.o

but just tested it, seems the above piggy.o is not needed.

Thanks & Regards,
	Wu Zhangjin

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-05-30  3:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-29 11:17 [PATCH] mips: drop CLEAN_FILES from arch/mips/Makefile Sam Ravnborg
2010-05-29 12:06 ` Wu Zhangjin
2010-05-29 19:40   ` [PATCHv2] " Sam Ravnborg
2010-05-29 19:40     ` Sam Ravnborg
2010-05-30  3:00     ` Wu Zhangjin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.