All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lee Schermerhorn <lee.schermerhorn@hp.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [rfc] forked kernel task and mm structures imbalanced on NUMA
Date: Tue, 01 Jun 2010 10:49:54 +0200	[thread overview]
Message-ID: <1275382194.27810.26330.camel@twins> (raw)
In-Reply-To: <1275380202.27810.26214.camel@twins>

On Tue, 2010-06-01 at 10:16 +0200, Peter Zijlstra wrote:
> I'd have to again look at wth happens to ->cpus_allowed, but I guess
> it should be fixable

Ah, I remember, cgroup_clone was a massive pain, Serge said he'd wanted
to kill that, but I don't think that ever happened.

    copy_process():
      if (current->nsproxy != p->nsproxy)
         ns_cgroup_clone()
           cgroup_clone()
             mutex_lock(inode->i_mutex)
             mutex_lock(cgroup_mutex)
             cgroup_attach_task()
           ss->can_attach()
               ss->attach() [ -> cpuset_attach() ]
                 cpuset_attach_task()
                   set_cpus_allowed_ptr();

was the code path that made set_cpus_allowed_ptr() exclusion against
fork interesting.



WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Nick Piggin <npiggin@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Lee Schermerhorn <lee.schermerhorn@hp.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [rfc] forked kernel task and mm structures imbalanced on NUMA
Date: Tue, 01 Jun 2010 10:49:54 +0200	[thread overview]
Message-ID: <1275382194.27810.26330.camel@twins> (raw)
In-Reply-To: <1275380202.27810.26214.camel@twins>

On Tue, 2010-06-01 at 10:16 +0200, Peter Zijlstra wrote:
> I'd have to again look at wth happens to ->cpus_allowed, but I guess
> it should be fixable

Ah, I remember, cgroup_clone was a massive pain, Serge said he'd wanted
to kill that, but I don't think that ever happened.

    copy_process():
      if (current->nsproxy != p->nsproxy)
         ns_cgroup_clone()
           cgroup_clone()
             mutex_lock(inode->i_mutex)
             mutex_lock(cgroup_mutex)
             cgroup_attach_task()
           ss->can_attach()
               ss->attach() [ -> cpuset_attach() ]
                 cpuset_attach_task()
                   set_cpus_allowed_ptr();

was the code path that made set_cpus_allowed_ptr() exclusion against
fork interesting.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-06-01  8:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  7:33 [rfc] forked kernel task and mm structures imbalanced on NUMA Nick Piggin
2010-06-01  7:33 ` Nick Piggin
2010-06-01  8:16 ` Peter Zijlstra
2010-06-01  8:16   ` Peter Zijlstra
2010-06-01  8:41   ` Nick Piggin
2010-06-01  8:41     ` Nick Piggin
2010-06-01  9:05     ` Peter Zijlstra
2010-06-01  9:05       ` Peter Zijlstra
2010-06-01  8:49   ` Peter Zijlstra [this message]
2010-06-01  8:49     ` Peter Zijlstra
2010-06-01 15:48 ` Andi Kleen
2010-06-01 15:48   ` Andi Kleen
2010-06-01 15:59   ` Nick Piggin
2010-06-01 15:59     ` Nick Piggin
2010-06-01 16:20     ` Andi Kleen
2010-06-01 16:20       ` Andi Kleen
2010-06-01 16:31       ` Nick Piggin
2010-06-01 16:31         ` Nick Piggin
2010-06-01 16:00 ` Peter Zijlstra
2010-06-01 16:00   ` Peter Zijlstra
2010-06-01 16:02   ` Peter Zijlstra
2010-06-01 16:02     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275382194.27810.26330.camel@twins \
    --to=peterz@infradead.org \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=npiggin@suse.de \
    --cc=serue@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.