All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: gregkh@suse.de, bzolnier@gmail.com, roel.kluin@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()
Date: Sat, 05 Jun 2010 06:41:49 +0200	[thread overview]
Message-ID: <1275712909.8509.25.camel@debian-hell> (raw)

This debug printk is only useful if you're debugging the staging drivers
2860 e 2870, but, if you're just using them, it becomes really annoying, because
it uselessly clobbers the kernel log. I guess this patch shouldn't really get merged,
but it's more like a request to remove these annoying debugging messages for normal users.
If I get any suggestion on how to implement this in a way acceptable to get it merged, I'll
be happy to create the "good" version  of the patch.

Thanks,

Giangiacomo

>From b24cc30ddad0bcd9a1fe00a7ecdd5dba4a3a4d06 Mon Sep 17 00:00:00 2001
From: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
Date: Sat, 5 Jun 2010 05:39:58 +0200
Subject: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()


Signed-off-by: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
---
 drivers/staging/rt2860/sta_ioctl.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rt2860/sta_ioctl.c b/drivers/staging/rt2860/sta_ioctl.c
index de4b627..f9aa6f2 100644
--- a/drivers/staging/rt2860/sta_ioctl.c
+++ b/drivers/staging/rt2860/sta_ioctl.c
@@ -1116,9 +1116,9 @@ int rt_ioctl_giwscan(struct net_device *dev,
 
 	data->length = current_ev - extra;
 	pAdapter->StaCfg.bScanReqIsFromWebUI = FALSE;
-	DBGPRINT(RT_DEBUG_ERROR,
+	/*DBGPRINT(RT_DEBUG_ERROR,
 		 ("===>rt_ioctl_giwscan. %d(%d) BSS returned, data->length = %d\n",
-		  i, pAdapter->ScanTab.BssNr, data->length));
+		  i, pAdapter->ScanTab.BssNr, data->length));*/
 	return 0;
 }
 
-- 
1.7.1



             reply	other threads:[~2010-06-05  4:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05  4:41 Giangiacomo Mariotti [this message]
2010-06-05 10:07 ` [PATCH] remove pointless debug printk in rt_ioctl_giwscan() Arnd Bergmann
2010-06-18 23:15   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275712909.8509.25.camel@debian-hell \
    --to=giangiacomo.mariotti@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.