From: Arnd Bergmann <arnd@arndb.de>
To: Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
gregkh@suse.de, bzolnier@gmail.com, roel.kluin@gmail.com,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] remove pointless debug printk in rt_ioctl_giwscan()
Date: Sat, 5 Jun 2010 12:07:39 +0200 [thread overview]
Message-ID: <201006051207.40040.arnd@arndb.de> (raw)
In-Reply-To: <1275712909.8509.25.camel@debian-hell>
On Saturday 05 June 2010, Giangiacomo Mariotti wrote:
> This debug printk is only useful if you're debugging the staging drivers
> 2860 e 2870, but, if you're just using them, it becomes really annoying, because
> it uselessly clobbers the kernel log. I guess this patch shouldn't really get merged,
> but it's more like a request to remove these annoying debugging messages for normal users.
> If I get any suggestion on how to implement this in a way acceptable to get it merged, I'll
> be happy to create the "good" version of the patch.
Ideally, drivers should not have their own debugging macros like this, but
instead use the kernel's own pr_debug() and (preferrably) dev_dbg() macros,
which are disabled by default.
For many of these debugging outputs, it's even better to kill them entirely
instead of converting to dev_dbg().
Do not put the line in comments though.
Arnd
next prev parent reply other threads:[~2010-06-05 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 4:41 [PATCH] remove pointless debug printk in rt_ioctl_giwscan() Giangiacomo Mariotti
2010-06-05 10:07 ` Arnd Bergmann [this message]
2010-06-18 23:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006051207.40040.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bzolnier@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=giangiacomo.mariotti@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.