Re: [RFC patches 12/13] SMS: introduce message ID API

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

Hi Inaky,

> > > +/**
> > > + * Create a random UUID
> > > + *
> > > + * \param msg_id Descriptor
> > > + *
> > > + * \internal
> > > + *
> > > + * Crams the msg_id ID buffer with random 32-bit numbers; because we
> > > + * use a byte based buffer, we play the cast to guint32 trick (as that
> > > + * is what g_random_int() returns).
> > > + */
> > 
> > can we just stick with gtk-doc like you had in your previous patches. I
> > think intermixing it with doxygen is a bad idea.
> 
> Yep, my bad, sorry.
> 
> In any case, picking this up from earlier:
> 
> I have my doubts on gtk-doc vs doxygen. I remember there was a thread
> somewhere (email? irc? voice?) on which system to settle on which never
> got finalized. I am not too satisfied with gtk-doc's limitations, I'd
> rather do doxygen. Does anyone have any preference on once vs the other?
> 
> In any case, when we settle on one, I'll have to go and cleanup all
> these to conform to it. I'll also write a quick summary with examples on
> how to use it in doc/.

my preference with gtk-doc is that it generates nicer documentation and
also makes devhelp files available.

Regards

Marcel