All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [RFC patches 04/13] sms_assembly_add_fragment_backup: clarify how insertion spot is found
Date: Fri, 28 May 2010 09:27:20 -0500	[thread overview]
Message-ID: <201005280927.20936.denkenz@gmail.com> (raw)
In-Reply-To: <8068e20eb9e130e16487497fe6098c2f44f273e0.1274903142.git.inaky.perez-gonzalez@intel.com>

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi Inaky,

> +		/* Iterate over the bitmap to find in which position
> +		 * should the fragment be inserted -- basically we
> +		 * walk each bit in the bitmap until the bit we care
> +		 * about (offset:bit) and count which are stored --
> +		 * that gives us in which position we have to insert. */

Patch has been applied.  However please keep your commit header to 50 
characters or less.  Also, the preferred style for multi-line comments is:
/* <empty line>
 * ... comment
 */

Regards,
-Denis

  reply	other threads:[~2010-05-28 14:27 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 19:49 [RFC patches 00/13] misc cleanups and SMS ID API Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 01/13] Update .gitignore to ignore cscope databases and backup files Inaky Perez-Gonzalez
2010-05-28 14:08   ` Marcel Holtmann
2010-05-28 14:17     ` =?unknown-8bit?q?Jo=C3=A3o?= Paulo Rechi Vita
2010-05-28 14:29       ` Marcel Holtmann
2010-06-08 22:13         ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 02/13] sms_send_message: add a short roadmap Inaky Perez-Gonzalez
2010-05-28 14:11   ` Marcel Holtmann
2010-06-08 22:00     ` Inaky Perez-Gonzalez
2010-05-28 14:34   ` Denis Kenzior
2010-06-08 22:37     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 03/13] documentation: add note about referencing standards Inaky Perez-Gonzalez
2010-05-28 14:13   ` Marcel Holtmann
2010-06-08 22:01     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 04/13] sms_assembly_add_fragment_backup: clarify how insertion spot is found Inaky Perez-Gonzalez
2010-05-28 14:27   ` Denis Kenzior [this message]
2010-06-08 22:10     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 05/13] util.h: Add BUILD_BUG_ON() and friends for compile-time assert checking Inaky Perez-Gonzalez
2010-05-28 14:17   ` Marcel Holtmann
2010-06-08 22:03     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 06/13] smutil.h: add missing header file dependencies Inaky Perez-Gonzalez
2010-05-28 14:19   ` Marcel Holtmann
2010-06-08 22:04     ` Inaky Perez-Gonzalez
2010-05-28 14:31   ` Denis Kenzior
2010-06-08 22:30     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 07/13] write_file: make transaction-safe Inaky Perez-Gonzalez
2010-05-28 14:43   ` Denis Kenzior
2010-06-08 22:38     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 08/13] storage: add __attribute__((format)) to {write, read}_file() for printf-like variable arg verification Inaky Perez-Gonzalez
2010-05-28 14:45   ` Denis Kenzior
2010-06-08 22:43     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 09/13] Add function doc headers to ofono_sms_{create, register} Inaky Perez-Gonzalez
2010-05-28 14:47   ` Denis Kenzior
2010-06-08 22:58     ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 10/13] doc: explain debugging options to -d, add a pointer in -h to manpage Inaky Perez-Gonzalez
2010-05-28 14:21   ` Marcel Holtmann
2010-06-08 22:07     ` Inaky Perez-Gonzalez
2010-06-08 23:13       ` Marcel Holtmann
2010-06-08 23:33         ` Inaky Perez-Gonzalez
2010-05-26 19:49 ` [RFC patches 11/13] automake: fix installation of udev rules in VPATH builds Inaky Perez-Gonzalez
2010-05-28 14:25   ` Marcel Holtmann
2010-05-28 14:50   ` Denis Kenzior
2010-05-26 19:49 ` [RFC patches 12/13] SMS: introduce message ID API Inaky Perez-Gonzalez
2010-05-28 14:27   ` Marcel Holtmann
2010-06-08 22:12     ` Inaky Perez-Gonzalez
2010-06-08 23:14       ` Marcel Holtmann
2010-05-26 19:49 ` [RFC patches 13/13] SMS: implement SHA256-based message IDs [incomplete] Inaky Perez-Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005280927.20936.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.