All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Miles Lane <miles.lane@gmail.com>
Cc: paulmck@linux.vnet.ibm.com, Vivek Goyal <vgoyal@redhat.com>,
	Eric Paris <eparis@redhat.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	nauman@google.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked  rcu_dereference_check() without protection!
Date: Wed, 09 Jun 2010 20:15:11 +0200	[thread overview]
Message-ID: <1276107311.1745.66.camel@laptop> (raw)
In-Reply-To: <1276106229.1745.65.camel@laptop>

On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote:
> +       /*
> +        * We're not in the pid-hash yet so no cgroup attach races, and the
> +        * cgroup is pinned by the parent running this.
> +        *
> +        * Silence PROVE_RCU.
> +        */ 

Hum,.. not sure that's actually true though, the parent itself is still
susceptible to races afaict..

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Miles Lane <miles.lane@gmail.com>
Cc: paulmck@linux.vnet.ibm.com, Vivek Goyal <vgoyal@redhat.com>,
	Eric Paris <eparis@redhat.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>,
	nauman@google.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Johannes Berg <johannes@sipsolutions.net>
Subject: Re: 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection!
Date: Wed, 09 Jun 2010 20:15:11 +0200	[thread overview]
Message-ID: <1276107311.1745.66.camel@laptop> (raw)
In-Reply-To: <1276106229.1745.65.camel@laptop>

On Wed, 2010-06-09 at 19:57 +0200, Peter Zijlstra wrote:
> +       /*
> +        * We're not in the pid-hash yet so no cgroup attach races, and the
> +        * cgroup is pinned by the parent running this.
> +        *
> +        * Silence PROVE_RCU.
> +        */ 

Hum,.. not sure that's actually true though, the parent itself is still
susceptible to races afaict..

  reply	other threads:[~2010-06-09 18:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-07 18:14 2.6.35-rc2-git1 - include/linux/cgroup.h:534 invoked rcu_dereference_check() without protection! Miles Lane
2010-06-07 18:14 ` Miles Lane
2010-06-08  0:19 ` Paul E. McKenney
2010-06-08  4:16   ` Miles Lane
2010-06-08  4:16     ` Miles Lane
2010-06-08  8:40     ` Peter Zijlstra
2010-06-08  8:40       ` Peter Zijlstra
2010-06-08 13:14       ` Miles Lane
2010-06-08 13:14         ` Miles Lane
2010-06-08 13:34         ` Peter Zijlstra
2010-06-08 13:34           ` Peter Zijlstra
2010-06-09 15:11           ` Miles Lane
2010-06-09 15:11             ` Miles Lane
2010-06-09 15:24             ` Peter Zijlstra
2010-06-09 15:24               ` Peter Zijlstra
2010-06-09 15:29               ` Miles Lane
2010-06-09 15:29                 ` Miles Lane
2010-06-09 17:00                 ` Miles Lane
2010-06-09 17:00                   ` Miles Lane
2010-06-09 17:57                   ` Peter Zijlstra
2010-06-09 17:57                     ` Peter Zijlstra
2010-06-09 18:15                     ` Peter Zijlstra [this message]
2010-06-09 18:15                       ` Peter Zijlstra
2010-06-09 21:15                       ` Miles Lane
2010-06-09 21:15                         ` Miles Lane
2010-06-09 21:20                         ` Peter Zijlstra
2010-06-09 21:20                           ` Peter Zijlstra
     [not found]                           ` <AANLkTilsDv59zbL7rbAgJByz_vSnZ0QlbK3dVJUX2VYQ@mail.gmail.com>
2010-06-22  9:44                             ` [PATCH] sched: silence PROVE_RCU in sched_fork() Peter Zijlstra
2010-06-23  7:25                               ` Li Zefan
2010-06-23  7:25                                 ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276107311.1745.66.camel@laptop \
    --to=peterz@infradead.org \
    --cc=eparis@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jens.axboe@oracle.com \
    --cc=johannes@sipsolutions.net \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=miles.lane@gmail.com \
    --cc=mingo@elte.hu \
    --cc=nauman@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.