From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, vamos@i4.informatik.uni-erlangen.de,
Christoph Egger <siccegge@cs.fau.de>,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] Removing dead CONFIG_SMP_750
Date: Thu, 10 Jun 2010 16:14:21 +1000 [thread overview]
Message-ID: <1276150461.1962.42.camel@pasglop> (raw)
In-Reply-To: <20100609123557.GJ7801@zod.rchland.ibm.com>
On Wed, 2010-06-09 at 08:35 -0400, Josh Boyer wrote:
> On Wed, Jun 09, 2010 at 12:00:21PM +0200, Christoph Egger wrote:
> >CONFIG_SMP_750 doesn't exist in Kconfig, therefore removing all
> >references for it from the source code.
>
> Yeah, we don't support SMP on 750 at the moment. This code was carried over
> from the arch/ppc days, and that code was present pre-git. I think we can
> drop it, but I'll leave that up to Ben. Maybe he has crazy plans for a 750 SMP
> board.
Nope :-) Though it would be nice to also remove the call sites too and
thus remove the macro entirely.
Cheers,
Ben.
> josh
>
> >
> >Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> >---
> > arch/powerpc/mm/tlb_hash32.c | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> >diff --git a/arch/powerpc/mm/tlb_hash32.c b/arch/powerpc/mm/tlb_hash32.c
> >index 8aaa8b7..925fecb 100644
> >--- a/arch/powerpc/mm/tlb_hash32.c
> >+++ b/arch/powerpc/mm/tlb_hash32.c
> >@@ -94,11 +94,7 @@ void tlb_flush(struct mmu_gather *tlb)
> > * the cache operations on the bus. Hence we need to use an IPI
> > * to get the other CPU(s) to invalidate their TLBs.
> > */
> >-#ifdef CONFIG_SMP_750
> >-#define FINISH_FLUSH smp_send_tlb_invalidate(0)
> >-#else
> > #define FINISH_FLUSH do { } while (0)
> >-#endif
> >
> > static void flush_range(struct mm_struct *mm, unsigned long start,
> > unsigned long end)
> >--
> >1.6.3.3
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >Linuxppc-dev@lists.ozlabs.org
> >https://lists.ozlabs.org/listinfo/linuxppc-dev
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: Christoph Egger <siccegge@cs.fau.de>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
vamos@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 3/5] Removing dead CONFIG_SMP_750
Date: Thu, 10 Jun 2010 16:14:21 +1000 [thread overview]
Message-ID: <1276150461.1962.42.camel@pasglop> (raw)
In-Reply-To: <20100609123557.GJ7801@zod.rchland.ibm.com>
On Wed, 2010-06-09 at 08:35 -0400, Josh Boyer wrote:
> On Wed, Jun 09, 2010 at 12:00:21PM +0200, Christoph Egger wrote:
> >CONFIG_SMP_750 doesn't exist in Kconfig, therefore removing all
> >references for it from the source code.
>
> Yeah, we don't support SMP on 750 at the moment. This code was carried over
> from the arch/ppc days, and that code was present pre-git. I think we can
> drop it, but I'll leave that up to Ben. Maybe he has crazy plans for a 750 SMP
> board.
Nope :-) Though it would be nice to also remove the call sites too and
thus remove the macro entirely.
Cheers,
Ben.
> josh
>
> >
> >Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> >---
> > arch/powerpc/mm/tlb_hash32.c | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> >diff --git a/arch/powerpc/mm/tlb_hash32.c b/arch/powerpc/mm/tlb_hash32.c
> >index 8aaa8b7..925fecb 100644
> >--- a/arch/powerpc/mm/tlb_hash32.c
> >+++ b/arch/powerpc/mm/tlb_hash32.c
> >@@ -94,11 +94,7 @@ void tlb_flush(struct mmu_gather *tlb)
> > * the cache operations on the bus. Hence we need to use an IPI
> > * to get the other CPU(s) to invalidate their TLBs.
> > */
> >-#ifdef CONFIG_SMP_750
> >-#define FINISH_FLUSH smp_send_tlb_invalidate(0)
> >-#else
> > #define FINISH_FLUSH do { } while (0)
> >-#endif
> >
> > static void flush_range(struct mm_struct *mm, unsigned long start,
> > unsigned long end)
> >--
> >1.6.3.3
> >
> >_______________________________________________
> >Linuxppc-dev mailing list
> >Linuxppc-dev@lists.ozlabs.org
> >https://lists.ozlabs.org/listinfo/linuxppc-dev
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2010-06-10 6:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 9:58 [PATCH 0/5] Removing dead code Christoph Egger
2010-06-09 9:59 ` [PATCH 1/5] Removing dead BOOK3E_MMU_TLB_STATS Christoph Egger
2010-06-10 5:20 ` Benjamin Herrenschmidt
2010-06-10 5:20 ` Benjamin Herrenschmidt
2010-06-09 9:59 ` [PATCH 2/5] Removing dead CONFIG_HIGHPTE Christoph Egger
2010-06-09 10:00 ` [PATCH 3/5] Removing dead CONFIG_SMP_750 Christoph Egger
2010-06-09 12:35 ` Josh Boyer
2010-06-09 12:35 ` Josh Boyer
2010-06-10 6:14 ` Benjamin Herrenschmidt [this message]
2010-06-10 6:14 ` Benjamin Herrenschmidt
2010-06-10 12:23 ` Christoph Egger
2010-06-10 12:23 ` Christoph Egger
2010-06-11 6:41 ` Benjamin Herrenschmidt
2010-06-11 6:41 ` Benjamin Herrenschmidt
2010-06-09 10:00 ` [PATCH 4/5] Removing dead CONFIG_SERIAL_TEXT_DEBUG Christoph Egger
2010-06-09 10:28 ` Josh Boyer
2010-06-09 10:28 ` Josh Boyer
2010-06-09 10:01 ` [PATCH 5/5] Removing dead CONFIG_PPC47x Christoph Egger
2010-06-09 11:02 ` [PATCH 5b/5] " Christoph Egger
2010-06-09 12:05 ` Josh Boyer
2010-06-09 12:05 ` Josh Boyer
2010-06-10 8:59 ` Benjamin Herrenschmidt
2010-06-10 8:59 ` Benjamin Herrenschmidt
2010-06-10 18:46 ` [PATCH 0/5] Removing dead code Joe Perches
2010-06-10 18:46 ` Joe Perches
2010-06-11 7:26 ` Reinhard Tartler
2010-06-11 7:26 ` Reinhard Tartler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276150461.1962.42.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=siccegge@cs.fau.de \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.