From: Artem Bityutskiy <dedekind1@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH 4/8] fs/ubifs: Use ERR_CAST
Date: Sat, 12 Jun 2010 11:53:28 +0000 [thread overview]
Message-ID: <1276343608.19028.118.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.1005221200050.13021@ask.diku.dk>
On Sat, 2010-05-22 at 12:00 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
> clear what is the purpose of the operation, which otherwise looks like a
> no-op.
Pushed to the ubifs-2.6.git tree, thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org,
Adrian Hunter <adrian.hunter@nokia.com>
Subject: Re: [PATCH 4/8] fs/ubifs: Use ERR_CAST
Date: Sat, 12 Jun 2010 14:53:28 +0300 [thread overview]
Message-ID: <1276343608.19028.118.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.1005221200050.13021@ask.diku.dk>
On Sat, 2010-05-22 at 12:00 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
> clear what is the purpose of the operation, which otherwise looks like a
> no-op.
Pushed to the ubifs-2.6.git tree, thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Adrian Hunter <adrian.hunter@nokia.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 4/8] fs/ubifs: Use ERR_CAST
Date: Sat, 12 Jun 2010 14:53:28 +0300 [thread overview]
Message-ID: <1276343608.19028.118.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.1005221200050.13021@ask.diku.dk>
On Sat, 2010-05-22 at 12:00 +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
> clear what is the purpose of the operation, which otherwise looks like a
> no-op.
Pushed to the ubifs-2.6.git tree, thank you!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-06-12 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 10:00 [PATCH 4/8] fs/ubifs: Use ERR_CAST Julia Lawall
2010-05-22 10:00 ` Julia Lawall
2010-06-12 11:53 ` Artem Bityutskiy [this message]
2010-06-12 11:53 ` Artem Bityutskiy
2010-06-12 11:53 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276343608.19028.118.camel@localhost \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@nokia.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.