From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: dhowells@redhat.com, oe-kbuild@lists.linux.dev, lkp@intel.com,
oe-kbuild-all@lists.linux.dev
Subject: Re: [dhowells-fs:netfs-next 10/16] fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'.
Date: Mon, 02 Mar 2026 11:17:19 +0000 [thread overview]
Message-ID: <1276684.1772450239@warthog.procyon.org.uk> (raw)
In-Reply-To: <202603011243.LsWeX4QE-lkp@intel.com>
Dan Carpenter <dan.carpenter@linaro.org> wrote:
> if (!mutex_trylock(&ictx->wb_lock)) {
> if (wbc->sync_mode == WB_SYNC_NONE) {
> netfs_stat(&netfs_n_wb_lock_skip);
> return 0;
>
> Unlock before returning?
If mutex_trylock() returns false, we don't have the lock. Note that it's a
"try" so it's not guaranteed to work.
David
next prev parent reply other threads:[~2026-03-02 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 4:48 [dhowells-fs:netfs-next 10/16] fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock' kernel test robot
2026-03-02 9:04 ` Dan Carpenter
2026-03-02 11:17 ` David Howells [this message]
2026-03-02 12:01 ` Dan Carpenter
2026-03-02 14:47 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276684.1772450239@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dan.carpenter@linaro.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.