Re: [dhowells-fs:netfs-next 10/16] fs/netfs/write_issue.c:850 netfs_writeback_single() warn: inconsistent returns '&ictx->wb_lock'.

[David Howells <dhowells@redhat.com>]

Dan Carpenter <dan.carpenter@linaro.org> wrote:

> a1cee75a302b7a David Howells 2026-02-28  842  cleanup_free:
> 
> But the goto cleanup_free gotos are still holding the lock.

I see it now, thanks.  I'm going to move cleanup_free: and change the end of
the function:

--- a/fs/netfs/write_issue.c
+++ b/fs/netfs/write_issue.c
@@ -839,11 +839,12 @@ int netfs_writeback_single(struct address_space *mapping,
 	 */
 	ret = netfs_wait_for_write(wreq);
 
-cleanup_free:
 	netfs_put_request(wreq, netfs_rreq_trace_put_return);
 	_leave(" = %d", ret);
 	return ret;
 
+cleanup_free:
+	netfs_put_request(wreq, netfs_rreq_trace_put_return);
 couldnt_start:
 	mutex_unlock(&ictx->wb_lock);
 	_leave(" = %d", ret);

David