All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 10/14] vpc: Use bdrv_(p)write_sync for metadata writes
Date: Tue, 22 Jun 2010 16:09:29 +0200	[thread overview]
Message-ID: <1277215773-27357-11-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1277215773-27357-1-git-send-email-kwolf@redhat.com>

Use bdrv_(p)write_sync to ensure metadata integrity in case of a crash.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vpc.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/block/vpc.c b/block/vpc.c
index f1f73e2..e50509e 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -261,7 +261,7 @@ static inline int64_t get_sector_offset(BlockDriverState *bs,
 
         s->last_bitmap_offset = bitmap_offset;
         memset(bitmap, 0xff, s->bitmap_size);
-        bdrv_pwrite(bs->file, bitmap_offset, bitmap, s->bitmap_size);
+        bdrv_pwrite_sync(bs->file, bitmap_offset, bitmap, s->bitmap_size);
     }
 
 //    printf("sector: %" PRIx64 ", index: %x, offset: %x, bioff: %" PRIx64 ", bloff: %" PRIx64 "\n",
@@ -311,7 +311,7 @@ static int rewrite_footer(BlockDriverState* bs)
     BDRVVPCState *s = bs->opaque;
     int64_t offset = s->free_data_block_offset;
 
-    ret = bdrv_pwrite(bs->file, offset, s->footer_buf, HEADER_SIZE);
+    ret = bdrv_pwrite_sync(bs->file, offset, s->footer_buf, HEADER_SIZE);
     if (ret < 0)
         return ret;
 
@@ -346,7 +346,8 @@ static int64_t alloc_block(BlockDriverState* bs, int64_t sector_num)
 
     // Initialize the block's bitmap
     memset(bitmap, 0xff, s->bitmap_size);
-    bdrv_pwrite(bs->file, s->free_data_block_offset, bitmap, s->bitmap_size);
+    bdrv_pwrite_sync(bs->file, s->free_data_block_offset, bitmap,
+        s->bitmap_size);
 
     // Write new footer (the old one will be overwritten)
     s->free_data_block_offset += s->block_size + s->bitmap_size;
@@ -357,7 +358,7 @@ static int64_t alloc_block(BlockDriverState* bs, int64_t sector_num)
     // Write BAT entry to disk
     bat_offset = s->bat_offset + (4 * index);
     bat_value = be32_to_cpu(s->pagetable[index]);
-    ret = bdrv_pwrite(bs->file, bat_offset, &bat_value, 4);
+    ret = bdrv_pwrite_sync(bs->file, bat_offset, &bat_value, 4);
     if (ret < 0)
         goto fail;
 
-- 
1.6.6.1

  parent reply	other threads:[~2010-06-22 14:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22 14:09 [Qemu-devel] [PULL 00/14] Block patches Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 01/14] scsi-bus: Add PERSISTENT_RESERVE_OUT SCSIRequest->cmd.mode setup Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 02/14] scsi-bus: Add MAINTENANCE_IN and MAINTENANCE_OUT SCSIRequest xfer and mode assignments Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 03/14] block: fix physical_block_size calculation Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 04/14] monitor: allow device to be ejected if no disk is inserted Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 05/14] block: Add bdrv_(p)write_sync Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 06/14] cow: Use bdrv_(p)write_sync for metadata writes Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 07/14] qcow: " Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 08/14] qcow2: " Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 09/14] vmdk: " Kevin Wolf
2010-06-22 14:09 ` Kevin Wolf [this message]
2010-06-22 14:09 ` [Qemu-devel] [PATCH 11/14] qemu-io: check registered fds in command_loop() Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 12/14] virtio-blk: fix the list operation in virtio_blk_load() Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 13/14] qcow2: Fix qemu-img check segfault on corrupted images Kevin Wolf
2010-06-22 14:09 ` [Qemu-devel] [PATCH 14/14] qcow2: Don't try to check tables that couldn't be loaded Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1277215773-27357-11-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.