All of lore.kernel.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] xilinx_dma: Edit device tree bindings documentation
Date: Wed, 14 Dec 2016 21:56:10 +0200	[thread overview]
Message-ID: <12776575.5mdqB62qf1@avalon> (raw)
In-Reply-To: <78b8d3b8540a2310818cf0c5b05adbc29e067981.1481735244.git.roliveir@synopsys.com>

Hi Ramiro,

Thank you for the patch.

On Wednesday 14 Dec 2016 17:18:23 Ramiro Oliveira wrote:
> Add reset property documentation for Xilinx DMA
> 
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
>  Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index
> a2b8bfa..7ebce72 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> @@ -40,6 +40,10 @@ Required properties for VDMA:
>  Optional properties:
>  - xlnx,include-sg: Tells configured for Scatter-mode in
>  	the hardware.
> +- resets : Must contain an entry for each entry in reset-names.
> +  See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> +  - reset

If the IP core has a single reset, can't we omit the name ?

>  Optional properties for AXI DMA:
>  - xlnx,mcdma: Tells whether configured for multi-channel mode in the
> hardware. Optional properties for VDMA:
> @@ -83,6 +87,8 @@ axi_vdma_0: axivdma at 40030000 {
>  	clocks = <&clk 0>, <&clk 1>, <&clk 2>, <&clk 3>, <&clk 4>;
>  	clock-names = "s_axi_lite_aclk", "m_axi_mm2s_aclk", "m_axi_s2mm_aclk",
>  		      "m_axis_mm2s_aclk", "s_axis_s2mm_aclk";
> +	resets = <&rst 2>;
> +	reset-names = "reset";
>  	dma-channel at 40030000 {
>  		compatible = "xlnx,axi-vdma-mm2s-channel";
>  		interrupts = < 0 54 4 >;

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com>
Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, vinod.koul@intel.com,
	robh+dt@kernel.org, mark.rutland@arm.com,
	michal.simek@xilinx.com, soren.brinkmann@xilinx.com,
	appana.durga.rao@xilinx.com, anuragku@xilinx.com,
	dan.j.williams@intel.com, CARLOS.PALMINHA@synopsys.com
Subject: Re: [PATCH 1/2] xilinx_dma: Edit device tree bindings documentation
Date: Wed, 14 Dec 2016 21:56:10 +0200	[thread overview]
Message-ID: <12776575.5mdqB62qf1@avalon> (raw)
In-Reply-To: <78b8d3b8540a2310818cf0c5b05adbc29e067981.1481735244.git.roliveir@synopsys.com>

Hi Ramiro,

Thank you for the patch.

On Wednesday 14 Dec 2016 17:18:23 Ramiro Oliveira wrote:
> Add reset property documentation for Xilinx DMA
> 
> Signed-off-by: Ramiro Oliveira <roliveir@synopsys.com>
> ---
>  Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt index
> a2b8bfa..7ebce72 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt
> @@ -40,6 +40,10 @@ Required properties for VDMA:
>  Optional properties:
>  - xlnx,include-sg: Tells configured for Scatter-mode in
>  	the hardware.
> +- resets : Must contain an entry for each entry in reset-names.
> +  See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> +  - reset

If the IP core has a single reset, can't we omit the name ?

>  Optional properties for AXI DMA:
>  - xlnx,mcdma: Tells whether configured for multi-channel mode in the
> hardware. Optional properties for VDMA:
> @@ -83,6 +87,8 @@ axi_vdma_0: axivdma@40030000 {
>  	clocks = <&clk 0>, <&clk 1>, <&clk 2>, <&clk 3>, <&clk 4>;
>  	clock-names = "s_axi_lite_aclk", "m_axi_mm2s_aclk", "m_axi_s2mm_aclk",
>  		      "m_axis_mm2s_aclk", "s_axis_s2mm_aclk";
> +	resets = <&rst 2>;
> +	reset-names = "reset";
>  	dma-channel@40030000 {
>  		compatible = "xlnx,axi-vdma-mm2s-channel";
>  		interrupts = < 0 54 4 >;

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2016-12-14 19:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14 17:18 [PATCH 0/2] xilinx_dma: Add external reset control Ramiro Oliveira
2016-12-14 17:18 ` Ramiro Oliveira
2016-12-14 17:18 ` Ramiro Oliveira
2016-12-14 17:18 ` [PATCH 1/2] xilinx_dma: Edit device tree bindings documentation Ramiro Oliveira
2016-12-14 17:18   ` Ramiro Oliveira
2016-12-14 19:56   ` Laurent Pinchart [this message]
2016-12-14 19:56     ` Laurent Pinchart
2016-12-14 17:18 ` [PATCH 2/2] xilinx_dma: Add reset support Ramiro Oliveira
2016-12-14 17:18   ` Ramiro Oliveira
2016-12-14 17:18   ` Ramiro Oliveira
2016-12-14 20:16   ` Laurent Pinchart
2016-12-14 20:16     ` Laurent Pinchart
2016-12-15 11:26     ` Ramiro Oliveira
2016-12-15 11:26       ` Ramiro Oliveira
2016-12-15 11:26       ` Ramiro Oliveira
2016-12-15 13:56       ` Laurent Pinchart
2016-12-15 13:56         ` Laurent Pinchart
2016-12-15 13:56         ` Laurent Pinchart
2016-12-23 10:26         ` Philipp Zabel
2016-12-23 10:26           ` Philipp Zabel
2016-12-23 10:26           ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12776575.5mdqB62qf1@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.