From: Daniel Walker <dwalker@codeaurora.org>
To: Greg Bean <gbean@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] msm: gpio: Add set_wake support to msm7200a-gpio's irq_chip.
Date: Tue, 06 Jul 2010 10:06:08 -0700 [thread overview]
Message-ID: <1278435968.27490.5.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <4C336020.3090206@codeaurora.org>
On Tue, 2010-07-06 at 09:56 -0700, Greg Bean wrote:
> >> Add power-management and irq_chip hooks to allow configuration
> >> of msm-gpio irq lines as wakeup sources.
> >
> > What level of correlation is there between power management and the wake
> > up hooks? Just irq_masks ?
>
> When the system sleeps, gpio-based irqs which are not configured as wake-up
> sources are disabled in the controller hardware to prevent latching and
> unwanted wakeups.
So you could make these two patches? It seems like they're relatively
distinct other than the one fairly ordered dependency you mention above.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] msm: gpio: Add set_wake support to msm7200a-gpio's irq_chip.
Date: Tue, 06 Jul 2010 10:06:08 -0700 [thread overview]
Message-ID: <1278435968.27490.5.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <4C336020.3090206@codeaurora.org>
On Tue, 2010-07-06 at 09:56 -0700, Greg Bean wrote:
> >> Add power-management and irq_chip hooks to allow configuration
> >> of msm-gpio irq lines as wakeup sources.
> >
> > What level of correlation is there between power management and the wake
> > up hooks? Just irq_masks ?
>
> When the system sleeps, gpio-based irqs which are not configured as wake-up
> sources are disabled in the controller hardware to prevent latching and
> unwanted wakeups.
So you could make these two patches? It seems like they're relatively
distinct other than the one fairly ordered dependency you mention above.
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-07-06 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-03 19:25 [PATCH v2] msm: gpio: Add set_wake support to msm7200a-gpio's irq_chip Gregory Bean
2010-07-03 19:25 ` Gregory Bean
2010-07-06 16:47 ` Daniel Walker
2010-07-06 16:47 ` Daniel Walker
2010-07-06 16:56 ` Greg Bean
2010-07-06 16:56 ` Greg Bean
2010-07-06 17:06 ` Daniel Walker [this message]
2010-07-06 17:06 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278435968.27490.5.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=gbean@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.