From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Eric Bénard" <eric@eukrea.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly
Date: Wed, 07 Jul 2010 17:17:11 +0300 [thread overview]
Message-ID: <1278512231.12733.23.camel@localhost> (raw)
In-Reply-To: <1276801147-4103-4-git-send-email-eric@eukrea.com>
On Thu, 2010-06-17 at 20:59 +0200, Eric Bénard wrote:
> The mtd layer is responsible to call mtd->{suspend,resume}. Doing it
> again in the driver is wrong and results in a warning:
>
> nand_resume called for a chip which is not in suspended state
>
> at resume time. Removing the calls from the resume and suspend
> functions makes them empty allowing them to be deleted completely.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Pushed to l2-mtd-2.6.git / dunno
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
WARNING: multiple messages have this Message-ID (diff)
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly
Date: Wed, 07 Jul 2010 17:17:11 +0300 [thread overview]
Message-ID: <1278512231.12733.23.camel@localhost> (raw)
In-Reply-To: <1276801147-4103-4-git-send-email-eric@eukrea.com>
On Thu, 2010-06-17 at 20:59 +0200, Eric B?nard wrote:
> The mtd layer is responsible to call mtd->{suspend,resume}. Doing it
> again in the driver is wrong and results in a warning:
>
> nand_resume called for a chip which is not in suspended state
>
> at resume time. Removing the calls from the resume and suspend
> functions makes them empty allowing them to be deleted completely.
>
> Signed-off-by: Eric B?nard <eric@eukrea.com>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Pushed to l2-mtd-2.6.git / dunno
--
Best Regards,
Artem Bityutskiy (????? ????????)
next prev parent reply other threads:[~2010-07-07 14:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 18:59 [PATCH v2] input/imx_keypad: add PM support Eric Bénard
2010-06-17 18:59 ` Eric Bénard
2010-06-17 18:59 ` [PATCH] eukrea_mbimx27: update keyboard platform data Eric Bénard
2010-06-17 18:59 ` [PATCH] eukrea_mbimx27-baseboard: fix compile when CONFIG_SPI_IMX is disabled Eric Bénard
2010-06-17 18:59 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly Eric Bénard
2010-06-17 18:59 ` Eric Bénard
2010-06-17 18:59 ` [PATCH] video/imxfb: fix suspend when screen is blanked Eric Bénard
2010-06-17 18:59 ` Eric Bénard
2010-06-17 18:59 ` [PATCH] mach-mx3/mach-mx31_3ds: update keypad registration Eric Bénard
2010-06-17 18:59 ` [PATCH] mxcmmc: convert to pm_ops and enable/disable clock Eric Bénard
2010-06-17 18:59 ` Eric Bénard
2010-06-17 19:22 ` [PATCH] video/imxfb: fix suspend when screen is blanked Luotao Fu
2010-06-17 19:22 ` Luotao Fu
2010-06-18 6:30 ` Eric Bénard
2010-06-18 6:30 ` Eric Bénard
2010-07-07 14:17 ` Artem Bityutskiy [this message]
2010-07-07 14:17 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly Artem Bityutskiy
2010-07-17 7:24 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend, resume} explicitly Eric Bénard
2010-07-17 7:24 ` Eric Bénard
2010-07-17 7:33 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly Artem Bityutskiy
2010-07-17 7:33 ` Artem Bityutskiy
2010-07-17 12:49 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend, resume} explicitly Eric Bénard
2010-07-17 12:49 ` Eric Bénard
2010-07-17 15:13 ` [PATCH v2] mtd/mxc_nand: don't call mtd->{suspend,resume} explicitly Artem Bityutskiy
2010-07-17 15:13 ` Artem Bityutskiy
2010-06-18 10:16 ` [PATCH v2] input/imx_keypad: add PM support Alberto Panizzo
2010-06-18 10:16 ` Alberto Panizzo
2010-06-18 14:37 ` Eric Bénard
2010-06-18 14:37 ` Eric Bénard
2010-06-18 17:40 ` Alberto Panizzo
2010-06-18 17:40 ` Alberto Panizzo
2010-06-18 17:50 ` Eric Bénard
2010-06-18 17:50 ` Eric Bénard
2010-06-24 16:39 ` Dmitry Torokhov
2010-06-24 16:39 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278512231.12733.23.camel@localhost \
--to=dedekind1@gmail.com \
--cc=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.