All of lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: "Gopinath, Thara" <thara@ti.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	Kevin Hilman <khilman@deeprootsystems.com>,
	Peter p2 De Schrijver <peter.de-schrijver@nokia.com>
Subject: RE: [PATCH 2/2] omap3: sr: improve errors handling
Date: Fri, 09 Jul 2010 19:02:46 +0300	[thread overview]
Message-ID: <1278691366.9953.149.camel@localhost> (raw)
In-Reply-To: <7A436F7769CA33409C6B44B358BFFF0C0133957982@dlee02.ent.ti.com>

On Fri, 2010-07-09 at 11:00 -0500, Menon, Nishanth wrote:
> > -----Original Message-----
> > From: Artem Bityutskiy [mailto:dedekind1@gmail.com]
> > Sent: Friday, July 09, 2010 10:51 AM
> > 
> > On Fri, 2010-07-09 at 10:51 -0500, Nishanth Menon wrote:
> > > > So the logic is:
> > > >
> > > > 1. The subject line is a short description which gives the idea what
> > the
> > > > commit is about. So, my subject line says:
> > > >   1.1. It is about omap3 (which is true)
> > > >   1.2. It is about sr (which is true)
> > > I think Thara's contention is that this is omap_device related- yeah SR
> > > is one of the users of omap_device, but there are much more folks using
> > > omap_device in l-o today.
> > 
> > I see. I'll try to come up with a better prefix, but if you suggest me a
> > good subject line, I'll be grateful :-)
> 
> Subject: omap: device: improve errors handling
> 
> Do not forget to check the 'platform_device_add_data()' error code
> in 'omap_device_build_ss()'.
> 
> How does that sound?

Good, thank you! I'll re-send the patch tomorrow unless you change the
subject yourself :-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-07-09 16:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-09 13:20 [PATCH 1/2] omap3: sr: fix memory leak and simplify the code Artem Bityutskiy
2010-07-09 13:20 ` [PATCH 2/2] omap3: sr: improve errors handling Artem Bityutskiy
2010-07-09 15:02   ` Nishanth Menon
2010-07-09 15:05   ` Gopinath, Thara
2010-07-09 15:44     ` Artem Bityutskiy
2010-07-09 15:51       ` Nishanth Menon
2010-07-09 15:50         ` Artem Bityutskiy
2010-07-09 16:00           ` Menon, Nishanth
2010-07-09 16:02             ` Artem Bityutskiy [this message]
2010-07-12 13:36   ` Artem Bityutskiy
2010-07-09 13:22 ` [PATCH 1/2] omap3: sr: fix memory leak and simplify the code Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278691366.9953.149.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=peter.de-schrijver@nokia.com \
    --cc=thara@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.