Re: [PATCH 2/2] omap3: sr: improve errors handling

[Nishanth Menon <nm@ti.com>]

Artem Bityutskiy had written, on 07/09/2010 08:20 AM, the following:
> From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> 
> Do not forget to check the 'platform_device_add_data()' error code
> in 'omap_device_build_ss()'.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
Acked-by: Nishanth Menon <nm@ti.com>

> ---
>  arch/arm/plat-omap/omap_device.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c
> index f2bd2e2..e8da192 100644
> --- a/arch/arm/plat-omap/omap_device.c
> +++ b/arch/arm/plat-omap/omap_device.c
> @@ -414,7 +414,9 @@ struct omap_device *omap_device_build_ss(const char *pdev_name, int pdev_id,
>  	od->pdev.num_resources = res_count;
>  	od->pdev.resource = res;
>  
> -	platform_device_add_data(&od->pdev, pdata, pdata_len);
> +	ret = platform_device_add_data(&od->pdev, pdata, pdata_len);
> +	if (ret)
> +		goto odbs_exit4;
>  
>  	od->pm_lats = pm_lats;
>  	od->pm_lats_cnt = pm_lats_cnt;


-- 
Regards,
Nishanth Menon