Re: [PATCH] Don't attach needless options when launch pygrub

[Ian Campbell <Ian.Campbell@eu.citrix.com>]

On Wed, 2010-07-14 at 12:21 +0100, Yu Zhiguo wrote:
> Ian Campbell wrote:
> > On Wed, 2010-07-14 at 12:01 +0100, Yu Zhiguo wrote:
> >> Ian Campbell wrote:
> >>> On Wed, 2010-07-14 at 11:07 +0100, Yu Zhiguo wrote:
> >>>>  Oh, yes. It seems that path of specified 'kernel' will be checked 
> >>>> in configure_image(). We can delete this check if 'bootloader' is
> >>>> existent.
> >>> That's only for kernel specified on the xm command line, not from the
> >>> configuration file, isn't it?
> >>>
> >>> I just confirmed that for a guest with grub configuration entries for
> >>> 2.6.32-5-686-bigmem and 2.6.26-2-686-bigmem (in that order) then
> >>>
> >>>         bootloader = "/usr/bin/pygrub"
> >>>         bootloader_args = "--quiet"
> >>>         
> >>>         kernel = "/boot/vmlinuz-2.6.26-2-686-bigmem"
> >>>         ramdisk = "/boot/initrd.img-2.6.26-2-686-bigmem"
> >>>         
> >>> will boot 2.6.26-2-686-bigmem whereas without the kernel and ramdisk
> >>> lines it will boot 2.6.32-5-686-bigmem.
> >>>
> >> I guess this DomU's grub.conf must has "kernel /boot/vmlinuz-2.6.26-2-686-bigmem".
> >>
> >> In other words, path of specified 'kernel' must be existent and *same* in both Dom0 and DomU.
> >> This is a problem, it is difficult for using.
> > 
> > No, in my domain 0:
> > 
> > # ls /boot/vmlinuz-2.6.26-2-686-bigmem
> > ls: cannot access /boot/vmlinuz-2.6.26-2-686-bigmem: No such file or directory
> > # ls /boot/vmlinuz-2.6.32-5-686-bigmem
> > ls: cannot access /boot/vmlinuz-2.6.32-5-686-bigmem: No such file or directory
> > 
> 
> yes. But what about menu.lst?

It contains /boot/vmlinuz-etcetc

> I think so.
> xl now cannot use 'bootloader' format (before your patchs),
> it just use 'kernel + ramdisk' format, so it should check 'kernel'
> is existent in Dom0 or not.
> 
> But xm can use 'bootloader' format, in this format, 'kernel' should not be
> check in Dom0 because it is path in DomU.

Correct.

> 
> 
> Yu
> 
> > Ian.
> > 
> >> I want to resolve this by using 'kernel' as DomU's kernel path, so it should not
> >> check it is existent or not in Dom0.
> > 
> >>
> >> Yu
> >>
> >>
> >>>>  What's your opinion?
> >>> This is long standing behaviour of the toolstack and although it's a
> >>> little odd it's not totally useless (it could be very useful if you
> >>> botch you grub configuration for example).
> >>>
> >>> I'll ask again, what do you think is wrong with the current behaviour
> >>> and what are the benefits to changing it?
> >>>
> >>> Ian.
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> > 
> > 
> > 
> > 
> > 
>