From: Yu Zhiguo <yuzg@cn.fujitsu.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH] Don't attach needless options when launch pygrub
Date: Wed, 14 Jul 2010 14:15:20 +0800 [thread overview]
Message-ID: <4C3D55F8.9010303@cn.fujitsu.com> (raw)
We should always run grub if bootloader is specified,
options 'kernel' and 'ramdisk' are needless.
Signed-off-by: Yu Zhiguo <yuzg@cn.fujitsu.com>
diff -r d867eb643fe4 -r 38d9dac1de56 tools/python/xen/xend/XendBootloader.py
--- a/tools/python/xen/xend/XendBootloader.py Tue Jul 13 18:17:28 2010 +0100
+++ b/tools/python/xen/xend/XendBootloader.py Wed Jul 14 22:18:58 2010 +0800
@@ -24,8 +24,7 @@
import pty, termios, fcntl
from xen.lowlevel import ptsname
-def bootloader(blexec, disk, dom, quiet = False, blargs = '', kernel = '',
- ramdisk = '', kernel_args = ''):
+def bootloader(blexec, disk, dom, quiet = False, blargs = '', kernel_args = ''):
"""Run the boot loader executable on the given disk and return a
config image.
@param blexec Binary to use as the boot loader
@@ -96,10 +95,6 @@
(child, m2) = pty.fork()
if (not child):
args = [ blexec ]
- if kernel:
- args.append("--kernel=%s" % kernel)
- if ramdisk:
- args.append("--ramdisk=%s" % ramdisk)
if kernel_args:
args.append("--args=%s" % kernel_args)
if quiet:
next reply other threads:[~2010-07-14 6:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 6:15 Yu Zhiguo [this message]
2010-07-14 6:47 ` [PATCH] Don't attach needless options when launch pygrub Ian Campbell
2010-07-14 7:29 ` Yu Zhiguo
2010-07-14 8:10 ` Ian Campbell
2010-07-14 9:36 ` Yu Zhiguo
2010-07-14 9:46 ` Ian Campbell
2010-07-14 10:07 ` Yu Zhiguo
2010-07-14 10:21 ` Yu Zhiguo
2010-07-14 10:22 ` Ian Campbell
2010-07-14 11:01 ` Yu Zhiguo
2010-07-14 11:10 ` Ian Campbell
2010-07-14 11:21 ` Yu Zhiguo
2010-07-14 12:33 ` Ian Campbell
2010-07-15 2:37 ` [PATCH] xm: needless to check 'kernel/ramdisk' is existent or not Yu Zhiguo
2010-07-15 7:42 ` Ian Campbell
2010-07-15 7:56 ` Ian Campbell
2010-07-15 3:44 ` [PATCH] Don't attach needless options when launch pygrub Zhigang Wang
2010-07-15 5:03 ` Yu Zhiguo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3D55F8.9010303@cn.fujitsu.com \
--to=yuzg@cn.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.