Re: [RFC 0/2] netfilter: xtables: CONDITION target implementation

[Luciano Coelho <luciano.coelho@nokia.com>]

On Mon, 2010-07-19 at 16:27 +0200, ext Changli Gao wrote:
> On Mon, Jul 19, 2010 at 10:15 PM, Luciano Coelho
> <luciano.coelho@nokia.com> wrote:
> > From: Luciano Coelho <coelho@testbed.(none)>
> >
> > Hi all,
> >
> > As discussed earlier, I've been looking for a way to enable and disable the
> > condition match automatically, in the netfilter tables themselves (ie. without
> > the need to use procfs).
> >
> > This is my initial implementation.  Please let me know how it looks.  The first
> > patch is based on the xt_condition patch that Jan sent to the list (but which
> > has not been finalized for inclusion yet).  Once the condition match gets
> > applied, I'll forward port my patch and submit it again.
> >
> > Cheers,
> > Luca.
> >
> > Luciano Coelho (2):
> >  netfilter: xt_condition: export list management code
> >  netfilter: xtables: implement CONDITION target
> >
> >  include/linux/netfilter/Kbuild         |    1 +
> >  include/linux/netfilter/xt_CONDITION.h |   39 +++++++++++
> >  include/linux/netfilter/xt_condition.h |   17 +++++-
> >  net/netfilter/Kconfig                  |   12 ++++
> >  net/netfilter/Makefile                 |    1 +
> >  net/netfilter/xt_CONDITION.c           |  112 ++++++++++++++++++++++++++++++++
> >  net/netfilter/xt_condition.c           |   82 ++++++++++++++----------
> 
> Why not combine xt_CONDITION.c and xt_condition.c into xt_condition.c,
> like xt_mark.c?

I just thought that someone may want to use the condition match without
using the CONDITION target, that's why I've put it in a different
module.

But I don't have a strong opinion about this.  If everybody agrees on
that, I can merge the code into a single module.

Thanks for your comment.

-- 
Cheers,
Luca.