All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linux-mm@kvack.org, greg@kroah.com, linux-kernel@vger.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 2/8] v3 Add new phys_index properties
Date: Tue, 20 Jul 2010 12:10:04 -0700	[thread overview]
Message-ID: <1279653004.9207.296.camel@nimitz> (raw)
In-Reply-To: <4C45A3AB.6090407@austin.ibm.com>

On Tue, 2010-07-20 at 08:24 -0500, Nathan Fontenot wrote:
> Update the 'phys_index' properties of a memory block to include a
> 'start_phys_index' which is the same as the current 'phys_index' property.
> This also adds an 'end_phys_index' property to indicate the id of the
> last section in th memory block.
> 
> Patch updated to keep the name of the phys_index property instead of
> renaming it to start_phys_index.

KAME is right on this.  We should keep the old one if at all possible.  

The only other thing we might want to do is move 'phys_index' to
'start_phys_index', and make a new 'phys_index' that does a WARN_ONCE(),
gives a deprecated warning, then calls the new 'start_phys_index' code.

So, basically make the new, more clear name, but keep the old one for a
while and deprecate it.  Maybe we could get away with removing it in ten
years. :)

-- Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@ozlabs.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	greg@kroah.com
Subject: Re: [PATCH 2/8] v3 Add new phys_index properties
Date: Tue, 20 Jul 2010 12:10:04 -0700	[thread overview]
Message-ID: <1279653004.9207.296.camel@nimitz> (raw)
In-Reply-To: <4C45A3AB.6090407@austin.ibm.com>

On Tue, 2010-07-20 at 08:24 -0500, Nathan Fontenot wrote:
> Update the 'phys_index' properties of a memory block to include a
> 'start_phys_index' which is the same as the current 'phys_index' property.
> This also adds an 'end_phys_index' property to indicate the id of the
> last section in th memory block.
> 
> Patch updated to keep the name of the phys_index property instead of
> renaming it to start_phys_index.

KAME is right on this.  We should keep the old one if at all possible.  

The only other thing we might want to do is move 'phys_index' to
'start_phys_index', and make a new 'phys_index' that does a WARN_ONCE(),
gives a deprecated warning, then calls the new 'start_phys_index' code.

So, basically make the new, more clear name, but keep the old one for a
while and deprecate it.  Maybe we could get away with removing it in ten
years. :)

-- Dave


WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linuxppc-dev@ozlabs.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	greg@kroah.com
Subject: Re: [PATCH 2/8] v3 Add new phys_index properties
Date: Tue, 20 Jul 2010 12:10:04 -0700	[thread overview]
Message-ID: <1279653004.9207.296.camel@nimitz> (raw)
In-Reply-To: <4C45A3AB.6090407@austin.ibm.com>

On Tue, 2010-07-20 at 08:24 -0500, Nathan Fontenot wrote:
> Update the 'phys_index' properties of a memory block to include a
> 'start_phys_index' which is the same as the current 'phys_index' property.
> This also adds an 'end_phys_index' property to indicate the id of the
> last section in th memory block.
> 
> Patch updated to keep the name of the phys_index property instead of
> renaming it to start_phys_index.

KAME is right on this.  We should keep the old one if at all possible.  

The only other thing we might want to do is move 'phys_index' to
'start_phys_index', and make a new 'phys_index' that does a WARN_ONCE(),
gives a deprecated warning, then calls the new 'start_phys_index' code.

So, basically make the new, more clear name, but keep the old one for a
while and deprecate it.  Maybe we could get away with removing it in ten
years. :)

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-07-20 19:10 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20  3:45 [PATCH 0/8] v3 De-couple sysfs memory directories from memory sections Nathan Fontenot
2010-07-20  3:45 ` Nathan Fontenot
2010-07-20  3:45 ` Nathan Fontenot
2010-07-20  3:51 ` [PATCH 1/8] v3 Move the find_memory_block() routine up Nathan Fontenot
2010-07-20  3:51   ` Nathan Fontenot
2010-07-20  3:51   ` Nathan Fontenot
2010-07-20  6:55   ` KAMEZAWA Hiroyuki
2010-07-20  6:55     ` KAMEZAWA Hiroyuki
2010-07-20  6:55     ` KAMEZAWA Hiroyuki
2010-07-20  3:52 ` [PATCH 2/8] v3 Add new phys_index properties Nathan Fontenot
2010-07-20  3:52   ` Nathan Fontenot
2010-07-20  3:52   ` Nathan Fontenot
2010-07-20  6:57   ` KAMEZAWA Hiroyuki
2010-07-20  6:57     ` KAMEZAWA Hiroyuki
2010-07-20  6:57     ` KAMEZAWA Hiroyuki
2010-07-20 13:24   ` Nathan Fontenot
2010-07-20 13:24     ` Nathan Fontenot
2010-07-20 13:24     ` Nathan Fontenot
2010-07-20 19:10     ` Dave Hansen [this message]
2010-07-20 19:10       ` Dave Hansen
2010-07-20 19:10       ` Dave Hansen
2010-07-20  3:53 ` [PATCH 3/8] v3 Add section count to memory_block Nathan Fontenot
2010-07-20  3:53   ` Nathan Fontenot
2010-07-20  3:53   ` Nathan Fontenot
2010-07-20  7:01   ` KAMEZAWA Hiroyuki
2010-07-20  7:01     ` KAMEZAWA Hiroyuki
2010-07-20  7:01     ` KAMEZAWA Hiroyuki
2010-07-20 13:26   ` Nathan Fontenot
2010-07-20 13:26     ` Nathan Fontenot
2010-07-20 13:26     ` Nathan Fontenot
2010-07-20  3:55 ` [PATCH 4/8] v3 Allow memory_block to span multiple memory sections Nathan Fontenot
2010-07-20  3:55   ` Nathan Fontenot
2010-07-20  3:55   ` Nathan Fontenot
2010-07-20  7:15   ` KAMEZAWA Hiroyuki
2010-07-20  7:15     ` KAMEZAWA Hiroyuki
2010-07-20  7:15     ` KAMEZAWA Hiroyuki
2010-07-20 13:28   ` Nathan Fontenot
2010-07-20 13:28     ` Nathan Fontenot
2010-07-20 13:28     ` Nathan Fontenot
2010-07-20 19:18   ` Dave Hansen
2010-07-20 19:18     ` Dave Hansen
2010-07-20 19:18     ` Dave Hansen
2010-07-24  3:09     ` Nathan Fontenot
2010-07-24  3:09       ` Nathan Fontenot
2010-07-24  3:09       ` Nathan Fontenot
2010-07-27  2:36       ` Dave Hansen
2010-07-27  2:36         ` Dave Hansen
2010-07-27  2:36         ` Dave Hansen
2010-07-26 19:10     ` Nathan Fontenot
2010-07-26 19:10       ` Nathan Fontenot
2010-07-26 19:10       ` Nathan Fontenot
2010-07-20 19:21   ` Dave Hansen
2010-07-20 19:21     ` Dave Hansen
2010-07-20 19:21     ` Dave Hansen
2010-07-20  3:56 ` [PATCH 5/8] v3 Update the find_memory_block declaration Nathan Fontenot
2010-07-20  3:56   ` Nathan Fontenot
2010-07-20  3:56   ` Nathan Fontenot
2010-07-20  7:16   ` KAMEZAWA Hiroyuki
2010-07-20  7:16     ` KAMEZAWA Hiroyuki
2010-07-20  7:16     ` KAMEZAWA Hiroyuki
2010-07-20  3:57 ` [PATCH 6/8] v3 Update the node sysfs code Nathan Fontenot
2010-07-20  3:57   ` Nathan Fontenot
2010-07-20  3:57   ` Nathan Fontenot
2010-07-20  7:17   ` KAMEZAWA Hiroyuki
2010-07-20  7:17     ` KAMEZAWA Hiroyuki
2010-07-20  7:17     ` KAMEZAWA Hiroyuki
2010-07-28 13:50   ` Brian King
2010-07-28 13:50     ` Brian King
2010-07-28 13:50     ` Brian King
2010-07-20  3:59 ` [PATCH 7/8] v3 Define memory_block_size_bytes() for ppc/pseries Nathan Fontenot
2010-07-20  3:59   ` Nathan Fontenot
2010-07-20  3:59   ` Nathan Fontenot
2010-07-21 20:27   ` Brian King
2010-07-21 20:27     ` Brian King
2010-07-21 20:27     ` Brian King
2010-07-20  3:59 ` [PATCH 8/8] v3 Update memory-hotplug documentation Nathan Fontenot
2010-07-20  3:59   ` Nathan Fontenot
2010-07-20  3:59   ` Nathan Fontenot
2010-07-20 19:23   ` Dave Hansen
2010-07-20 19:23     ` Dave Hansen
2010-07-20 19:23     ` Dave Hansen
2010-07-31  5:36 ` [PATCH 0/8] v3 De-couple sysfs memory directories from memory sections Benjamin Herrenschmidt
2010-07-31  5:36   ` Benjamin Herrenschmidt
2010-07-31  5:36   ` Benjamin Herrenschmidt
2010-07-31 19:55   ` Greg KH
2010-07-31 19:55     ` Greg KH
2010-07-31 19:55     ` Greg KH
2010-08-01  0:27     ` Benjamin Herrenschmidt
2010-08-01  0:27       ` Benjamin Herrenschmidt
2010-08-01  0:27       ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279653004.9207.296.camel@nimitz \
    --to=dave@linux.vnet.ibm.com \
    --cc=greg@kroah.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=nfont@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.