[PATCH] drm: add "auto" dithering method

[PATCH] drm: add "auto" dithering method

[Ben Skeggs]

From: Ben Skeggs <bskeggs@redhat.com>

There's no convenient/reliable way for drivers to both obey the dithering
mode property, and to be able to attempt to provide a good default in all
cases.

This commit adds an "auto" method to the property which drivers can default
to if they wish, whilst still allowing the user to override the choice as
they do now.

Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
---
 drivers/gpu/drm/drm_crtc.c |    1 +
 include/drm/drm_mode.h     |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 57cea01..c359c83 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -80,6 +80,7 @@ static struct drm_prop_enum_list drm_dithering_mode_enum_list[] =
 {
 	{ DRM_MODE_DITHERING_OFF, "Off" },
 	{ DRM_MODE_DITHERING_ON, "On" },
+	{ DRM_MODE_DITHERING_AUTO, "Automatic" },
 };
 
 /*
diff --git a/include/drm/drm_mode.h b/include/drm/drm_mode.h
index c5ba163..0fc7397 100644
--- a/include/drm/drm_mode.h
+++ b/include/drm/drm_mode.h
@@ -74,6 +74,7 @@
 /* Dithering mode options */
 #define DRM_MODE_DITHERING_OFF	0
 #define DRM_MODE_DITHERING_ON	1
+#define DRM_MODE_DITHERING_AUTO 2
 
 /* Dirty info options */
 #define DRM_MODE_DIRTY_OFF      0
-- 
1.7.1.1

Re: [PATCH] drm: add "auto" dithering method

[Dave Airlie]

On Fri, 2010-07-16 at 15:09 +1000, Ben Skeggs wrote:
> From: Ben Skeggs <bskeggs@redhat.com>
> 
> There's no convenient/reliable way for drivers to both obey the dithering
> mode property, and to be able to attempt to provide a good default in all
> cases.
> 
> This commit adds an "auto" method to the property which drivers can default
> to if they wish, whilst still allowing the user to override the choice as
> they do now.

Pushed to drm-core-next.

Thanks,
Dave.