From: Marcel Holtmann <marcel@holtmann.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-wireless@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux@arm.linux.org.uk,
Chikkature Rajashekar Madhusudhan <madhu.cr@ti.com>,
Luciano Coelho <luciano.coelho@nokia.com>,
akpm@linux-foundation.org, San Mehat <san@google.com>,
Roger Quadros <roger.quadros@nokia.com>,
Tony Lindgren <tony@atomide.com>,
Nicolas Pitre <nico@fluxnic.net>,
Pandita Vikram <vikram.pandita@ti.com>,
Kalle Valo <kalle.valo@iki.fi>
Subject: Re: [PATCH v2 01/20] sdio: add TI + wl1271 ids
Date: Wed, 21 Jul 2010 10:58:54 -0700 [thread overview]
Message-ID: <1279735134.3035.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1279733634-21974-2-git-send-email-ohad@wizery.com>
Hi Ohad,
> Add SDIO IDs for TI and for TI's wl1271 wlan device.
>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> include/linux/mmc/sdio_ids.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 33b2ea0..0d313c6 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -43,4 +43,7 @@
> #define SDIO_DEVICE_ID_SIANO_NOVA_A0 0x1100
> #define SDIO_DEVICE_ID_SIANO_STELLAR 0x5347
>
> +#define SDIO_VENDOR_ID_TI 0x0097
> +#define SDIO_DEVICE_ID_TI_WL1271 0x4076
> +
are we still doing this non-sense for no real reason. What is so wrong
with keeping the IDs inside the driver code?
Personally I don't even see a point for these ID defines at all. Just
use the bare numbers in SDIO_DEVICE and put a comment above what kind of
device this is.
Regards
Marcel
WARNING: multiple messages have this Message-ID (diff)
From: marcel@holtmann.org (Marcel Holtmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 01/20] sdio: add TI + wl1271 ids
Date: Wed, 21 Jul 2010 10:58:54 -0700 [thread overview]
Message-ID: <1279735134.3035.9.camel@localhost.localdomain> (raw)
In-Reply-To: <1279733634-21974-2-git-send-email-ohad@wizery.com>
Hi Ohad,
> Add SDIO IDs for TI and for TI's wl1271 wlan device.
>
> Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> ---
> include/linux/mmc/sdio_ids.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h
> index 33b2ea0..0d313c6 100644
> --- a/include/linux/mmc/sdio_ids.h
> +++ b/include/linux/mmc/sdio_ids.h
> @@ -43,4 +43,7 @@
> #define SDIO_DEVICE_ID_SIANO_NOVA_A0 0x1100
> #define SDIO_DEVICE_ID_SIANO_STELLAR 0x5347
>
> +#define SDIO_VENDOR_ID_TI 0x0097
> +#define SDIO_DEVICE_ID_TI_WL1271 0x4076
> +
are we still doing this non-sense for no real reason. What is so wrong
with keeping the IDs inside the driver code?
Personally I don't even see a point for these ID defines at all. Just
use the bare numbers in SDIO_DEVICE and put a comment above what kind of
device this is.
Regards
Marcel
next prev parent reply other threads:[~2010-07-21 17:59 UTC|newest]
Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 17:33 [PATCH v2 00/20] native support for wl1271 on ZOOM Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 01/20] sdio: add TI + wl1271 ids Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:58 ` Marcel Holtmann [this message]
2010-07-21 17:58 ` Marcel Holtmann
2010-07-22 23:38 ` Ohad Ben-Cohen
2010-07-22 23:38 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 02/20] wireless: wl1271: remove SDIO IDs from driver Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 03/20] mmc: support embedded data field in mmc_host Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-28 19:47 ` Vitaly Wool
2010-07-28 19:47 ` Vitaly Wool
2010-07-29 6:00 ` Ohad Ben-Cohen
2010-07-29 6:00 ` Ohad Ben-Cohen
2010-07-29 16:16 ` Vitaly Wool
2010-07-29 16:16 ` Vitaly Wool
2010-08-02 15:54 ` Ohad Ben-Cohen
2010-08-02 15:54 ` Ohad Ben-Cohen
2010-08-02 15:54 ` Ohad Ben-Cohen
[not found] ` <AANLkTimZQKj7H_GeE=+O9cwxEMTR+LhfFbt=AyXGzN3d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-02 16:25 ` Vitaly Wool
2010-08-02 16:25 ` Vitaly Wool
2010-08-02 16:25 ` Vitaly Wool
2010-08-02 21:35 ` Ohad Ben-Cohen
2010-08-02 21:35 ` Ohad Ben-Cohen
2010-08-03 14:17 ` Vitaly Wool
2010-08-03 14:17 ` Vitaly Wool
[not found] ` <AANLkTin4m8gJR50zwMB2b0jRMHdNA6CQToKBTAhOL9wF-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-04 11:24 ` Ohad Ben-Cohen
2010-08-04 11:24 ` Ohad Ben-Cohen
2010-08-04 11:24 ` Ohad Ben-Cohen
[not found] ` <AANLkTinu2S19r8fueM-jVkc35XL2G0Z16BddE92Ci9KB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-08-04 11:41 ` Russell King - ARM Linux
2010-08-04 11:41 ` Russell King - ARM Linux
2010-08-04 11:41 ` Russell King - ARM Linux
2010-08-04 12:42 ` Ohad Ben-Cohen
2010-08-04 12:42 ` Ohad Ben-Cohen
2010-08-04 14:01 ` Vitaly Wool
2010-08-04 14:01 ` Vitaly Wool
2010-08-06 7:07 ` Linus Walleij
2010-08-06 7:07 ` Linus Walleij
2010-08-06 10:02 ` Ohad Ben-Cohen
2010-08-06 10:02 ` Ohad Ben-Cohen
2010-08-06 14:46 ` Russell King - ARM Linux
2010-08-06 14:46 ` Russell King - ARM Linux
[not found] ` <20100806144605.GA21015-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2010-08-06 16:53 ` Nicolas Pitre
2010-08-06 16:53 ` Nicolas Pitre
2010-08-06 16:53 ` Nicolas Pitre
2010-07-21 17:33 ` [PATCH v2 05/20] omap zoom3: wlan board muxing Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 06/20] wireless: wl1271: make wl12xx.h common to both spi and sdio Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 07/20] wireless: wl1271: support return value for the set power func Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 08/20] wireless: wl1271: take irq info from private board data Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 10/20] omap: zoom: add fixed regulator device for wlan Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:59 ` Mark Brown
2010-07-21 17:59 ` Mark Brown
2010-07-22 11:16 ` Roger Quadros
2010-07-22 11:16 ` Roger Quadros
2010-07-22 23:13 ` Ohad Ben-Cohen
2010-07-22 23:13 ` Ohad Ben-Cohen
2010-07-22 23:13 ` Ohad Ben-Cohen
[not found] ` <AANLkTin2dyLNo1RMQgLG-4DtN-CsXqNNLAfITXDbMIvl-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-23 9:15 ` Mark Brown
2010-07-23 9:15 ` Mark Brown
2010-07-23 9:15 ` Mark Brown
2010-07-25 10:40 ` Ohad Ben-Cohen
2010-07-25 10:40 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 11/20] omap: hsmmc: support mmc3 regulator power control Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
[not found] ` <1279733634-21974-1-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-07-21 17:33 ` [PATCH v2 04/20] omap zoom2: wlan board muxing Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 09/20] wireless: wl1271: make ref_clock configurable by board Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 12/20] omap: hsmmc: allow board-specific settings of private mmc data Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 13/20] omap: zoom: add mmc3/wl1271 device support Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 18/20] mmc: sdio: enable a default power off mode of the card Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-22 11:35 ` Roger Quadros
2010-07-22 11:35 ` Roger Quadros
[not found] ` <4C482D01.1040109-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-07-25 12:40 ` Ohad Ben-Cohen
2010-07-25 12:40 ` Ohad Ben-Cohen
2010-07-25 12:40 ` Ohad Ben-Cohen
2010-07-25 13:56 ` Nicolas Pitre
2010-07-25 13:56 ` Nicolas Pitre
[not found] ` <alpine.LFD.2.00.1007250953400.25246-QuJgVwGFrdf/9pzu0YdTqQ@public.gmane.org>
2010-07-25 14:05 ` Ohad Ben-Cohen
2010-07-25 14:05 ` Ohad Ben-Cohen
2010-07-25 14:05 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 20/20] wireless: wl1271: call SDIO claim/release power API Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-22 22:56 ` [PATCH v2 00/20] native support for wl1271 on ZOOM Nicolas Pitre
2010-07-22 22:56 ` Nicolas Pitre
2010-07-22 22:56 ` Nicolas Pitre
2010-07-22 23:56 ` Ohad Ben-Cohen
2010-07-22 23:56 ` Ohad Ben-Cohen
2010-07-22 23:56 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 14/20] mmc: sdio: fully reconfigure oldcard on resume Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 15/20] mmc: sdio: verify existence of resume handler Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 16/20] mmc: introduce API to control the card's power Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 17/20] mmc: sdio: relocate sdio_set_block_size call Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` [PATCH v2 19/20] omap: zoom: keep the MMC3 wl1271 device powered off Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
2010-07-21 17:33 ` Ohad Ben-Cohen
[not found] ` <1279733634-21974-20-git-send-email-ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org>
2010-07-21 18:55 ` Gabay, Benzy
2010-07-21 18:55 ` Gabay, Benzy
2010-07-21 18:55 ` Gabay, Benzy
2010-07-22 23:18 ` Ohad Ben-Cohen
2010-07-22 23:18 ` Ohad Ben-Cohen
2010-07-22 23:18 ` Ohad Ben-Cohen
[not found] ` <AANLkTim3RWv2-qi9UMg1imwKTJuh3GstdjMTxz64uOHf-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-07-26 18:33 ` Gabay, Benzy
2010-07-26 18:33 ` Gabay, Benzy
2010-07-26 18:33 ` Gabay, Benzy
2010-07-21 18:55 ` Gabay, Benzy
2010-07-26 19:30 ` [PATCH v2 00/20] native support for wl1271 on ZOOM John W. Linville
2010-07-26 19:30 ` John W. Linville
[not found] ` <20100726193028.GG3903-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2010-07-27 9:32 ` Ohad Ben-Cohen
2010-07-27 9:32 ` Ohad Ben-Cohen
2010-07-27 9:32 ` Ohad Ben-Cohen
2010-08-02 8:16 ` Luciano Coelho
2010-08-02 8:16 ` Luciano Coelho
2010-08-02 11:42 ` Tony Lindgren
2010-08-02 11:42 ` Tony Lindgren
2010-08-02 11:42 ` Tony Lindgren
2010-08-02 12:08 ` Ohad Ben-Cohen
2010-08-02 12:08 ` Ohad Ben-Cohen
[not found] ` <20100802114256.GE12293-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-08-02 15:12 ` Vitaly Wool
2010-08-02 15:12 ` Vitaly Wool
2010-08-02 15:12 ` Vitaly Wool
2010-08-02 15:59 ` Ohad Ben-Cohen
2010-08-02 15:59 ` Ohad Ben-Cohen
2010-08-02 16:19 ` Vitaly Wool
2010-08-02 16:19 ` Vitaly Wool
2010-08-02 16:40 ` Ohad Ben-Cohen
2010-08-02 16:40 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279735134.3035.9.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=akpm@linux-foundation.org \
--cc=kalle.valo@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luciano.coelho@nokia.com \
--cc=madhu.cr@ti.com \
--cc=nico@fluxnic.net \
--cc=ohad@wizery.com \
--cc=roger.quadros@nokia.com \
--cc=san@google.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.