From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Seungwhan Youn <claude.youn@gmail.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Joonyoung Shim <jy0922.shim@samsung.com>
Subject: Re: [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI
Date: Thu, 22 Jul 2010 11:15:52 +0100 [thread overview]
Message-ID: <1279793752.3083.40.camel@odin> (raw)
In-Reply-To: <AANLkTin660THXzF3MXTEMbscB84Axd-roKgZnIfcK1O3@mail.gmail.com>
On Thu, 2010-07-22 at 17:26 +0900, Seungwhan Youn wrote:
> >>>>> + return snd_soc_register_dai(dev, drv);
> >>>> How about s3c64xx-i2s? I think, if this patch fixes all errors in
> >>> Sorry, I confused your comment.
> >>> What do you mean "How about s3c64xx-i2s" ?
> >>
> >> Actually 'sound/soc/s3c24xx/s3c64xx-i2s.c' has same error.
> >>
> >> So, If this patch's purpose is to fix compile error, my opinion is
> >> that this patch fix all the same errors in 'sound/soc/s3c24xx/'.
> >
> > The 'sound/soc/s3c24xx/s3c64xx-i2s.c' haven't directly called
> > 'snd_soc_register_dai()' function.
> > It is call 's3c_i2sv2_register_dai()' in 'sound/soc/s3c24xx/s3c-i2s-v2.c'
> > to register a DAI.
> >
>
> Oh, I was confused about this even I modify this few days ago.
> I'm sorry that I make you to be confused.
>
I'm confused too ;)
Is this to be applied or not ?
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-07-22 10:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 5:14 [PATCH] ASoC: multi-component: SAMSUNG: Fix compile error when registering a DAI Chanwoo Choi
2010-07-22 7:35 ` Seungwhan Youn
2010-07-22 7:45 ` Chanwoo Choi
2010-07-22 7:55 ` Seungwhan Youn
2010-07-22 8:05 ` Chanwoo Choi
2010-07-22 8:26 ` Seungwhan Youn
2010-07-22 10:15 ` Liam Girdwood [this message]
2010-07-22 10:43 ` Seungwhan Youn
2010-07-22 11:42 ` Liam Girdwood
2010-07-22 10:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279793752.3083.40.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=claude.youn@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.