From: Andy Walls <awalls@md.metrocast.net>
To: Dan Carpenter <error27@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Ian Armstrong <ian@iarmst.demon.co.uk>,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] V4L: ivtv: remove unneeded NULL checks
Date: Fri, 23 Jul 2010 11:46:47 +0000 [thread overview]
Message-ID: <1279885607.2013.8.camel@morgan.silverblock.net> (raw)
In-Reply-To: <20100723101232.GE26313@bicker>
On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote:
> In ivtvfb_callback_cleanup() we dereference "itv" before checking that
> it's NULL. "itv" is assigned with container_of() which basically never
> returns a NULL pointer so the check is pointless. I removed it, along
> with a similar check in ivtvfb_callback_init().
>
> I considered adding a check for v4l2_dev, but I looked at the code and I
> don't think that can be NULL either.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Hi Dan,
Thanks, but Jiri Slaby already caught this one:
https://patchwork.kernel.org/patch/112725/
I'm going to let Mauro pick up Jiri's patch out of patchwork.
Regards,
Andy
> diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
> index 2c2d862..be03a71 100644
> --- a/drivers/media/video/ivtv/ivtvfb.c
> +++ b/drivers/media/video/ivtv/ivtvfb.c
> @@ -1239,7 +1239,7 @@ static int __init ivtvfb_callback_init(struct device *dev, void *p)
> struct v4l2_device *v4l2_dev = dev_get_drvdata(dev);
> struct ivtv *itv = container_of(v4l2_dev, struct ivtv, v4l2_dev);
>
> - if (itv && (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
> + if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
> if (ivtvfb_init_card(itv) = 0) {
> IVTVFB_INFO("Framebuffer registered on %s\n",
> itv->v4l2_dev.name);
> @@ -1255,7 +1255,7 @@ static int ivtvfb_callback_cleanup(struct device *dev, void *p)
> struct ivtv *itv = container_of(v4l2_dev, struct ivtv, v4l2_dev);
> struct osd_info *oi = itv->osd_info;
>
> - if (itv && (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
> + if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
> if (unregister_framebuffer(&itv->osd_info->ivtvfb_info)) {
> IVTVFB_WARN("Framebuffer %d is in use, cannot unload\n",
> itv->instance);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andy Walls <awalls@md.metrocast.net>
To: Dan Carpenter <error27@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Ian Armstrong <ian@iarmst.demon.co.uk>,
ivtv-devel@ivtvdriver.org, linux-media@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch -next] V4L: ivtv: remove unneeded NULL checks
Date: Fri, 23 Jul 2010 07:46:47 -0400 [thread overview]
Message-ID: <1279885607.2013.8.camel@morgan.silverblock.net> (raw)
In-Reply-To: <20100723101232.GE26313@bicker>
On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote:
> In ivtvfb_callback_cleanup() we dereference "itv" before checking that
> it's NULL. "itv" is assigned with container_of() which basically never
> returns a NULL pointer so the check is pointless. I removed it, along
> with a similar check in ivtvfb_callback_init().
>
> I considered adding a check for v4l2_dev, but I looked at the code and I
> don't think that can be NULL either.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Hi Dan,
Thanks, but Jiri Slaby already caught this one:
https://patchwork.kernel.org/patch/112725/
I'm going to let Mauro pick up Jiri's patch out of patchwork.
Regards,
Andy
> diff --git a/drivers/media/video/ivtv/ivtvfb.c b/drivers/media/video/ivtv/ivtvfb.c
> index 2c2d862..be03a71 100644
> --- a/drivers/media/video/ivtv/ivtvfb.c
> +++ b/drivers/media/video/ivtv/ivtvfb.c
> @@ -1239,7 +1239,7 @@ static int __init ivtvfb_callback_init(struct device *dev, void *p)
> struct v4l2_device *v4l2_dev = dev_get_drvdata(dev);
> struct ivtv *itv = container_of(v4l2_dev, struct ivtv, v4l2_dev);
>
> - if (itv && (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
> + if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
> if (ivtvfb_init_card(itv) == 0) {
> IVTVFB_INFO("Framebuffer registered on %s\n",
> itv->v4l2_dev.name);
> @@ -1255,7 +1255,7 @@ static int ivtvfb_callback_cleanup(struct device *dev, void *p)
> struct ivtv *itv = container_of(v4l2_dev, struct ivtv, v4l2_dev);
> struct osd_info *oi = itv->osd_info;
>
> - if (itv && (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT)) {
> + if (itv->v4l2_cap & V4L2_CAP_VIDEO_OUTPUT) {
> if (unregister_framebuffer(&itv->osd_info->ivtvfb_info)) {
> IVTVFB_WARN("Framebuffer %d is in use, cannot unload\n",
> itv->instance);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-07-23 11:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 10:12 [patch -next] V4L: ivtv: remove unneeded NULL checks Dan Carpenter
2010-07-23 10:12 ` Dan Carpenter
2010-07-23 11:46 ` Andy Walls [this message]
2010-07-23 11:46 ` Andy Walls
2010-07-23 12:00 ` Dan Carpenter
2010-07-23 12:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279885607.2013.8.camel@morgan.silverblock.net \
--to=awalls@md.metrocast.net \
--cc=error27@gmail.com \
--cc=ian@iarmst.demon.co.uk \
--cc=ivtv-devel@ivtvdriver.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.