All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] afs: do not set task state after schedule_timeout()
Date: Mon, 26 Jul 2010 08:27:09 +0000	[thread overview]
Message-ID: <1280132829-8224-1-git-send-email-segooon@gmail.com> (raw)

schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
to set it explicitly.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
 fs/afs/vlocation.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c
index 9ac260d..21f270d 100644
--- a/fs/afs/vlocation.c
+++ b/fs/afs/vlocation.c
@@ -130,7 +130,6 @@ static int afs_vlocation_access_vl_by_id(struct afs_vlocation *vl,
 					/* second+ BUSY - sleep a little bit */
 					set_current_state(TASK_UNINTERRUPTIBLE);
 					schedule_timeout(1);
-					__set_current_state(TASK_RUNNING);
 				}
 				continue;
 			}
-- 
1.7.0.4


WARNING: multiple messages have this Message-ID (diff)
From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: David Howells <dhowells@redhat.com>, Tejun Heo <tj@kernel.org>,
	linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] afs: do not set task state after schedule_timeout()
Date: Mon, 26 Jul 2010 12:27:09 +0400	[thread overview]
Message-ID: <1280132829-8224-1-git-send-email-segooon@gmail.com> (raw)

schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
to set it explicitly.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
 fs/afs/vlocation.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c
index 9ac260d..21f270d 100644
--- a/fs/afs/vlocation.c
+++ b/fs/afs/vlocation.c
@@ -130,7 +130,6 @@ static int afs_vlocation_access_vl_by_id(struct afs_vlocation *vl,
 					/* second+ BUSY - sleep a little bit */
 					set_current_state(TASK_UNINTERRUPTIBLE);
 					schedule_timeout(1);
-					__set_current_state(TASK_RUNNING);
 				}
 				continue;
 			}
-- 
1.7.0.4


             reply	other threads:[~2010-07-26  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-26  8:27 Kulikov Vasiliy [this message]
2010-07-26  8:27 ` [PATCH] afs: do not set task state after schedule_timeout() Kulikov Vasiliy
2010-07-26 11:32 ` David Howells
2010-07-26 11:32   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280132829-8224-1-git-send-email-segooon@gmail.com \
    --to=segooon@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.