From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Chris Mason <chris.mason@oracle.com>, Tejun Heo <tj@kernel.org>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: set task state with schedule_timeout_uninterruptible()
Date: Mon, 26 Jul 2010 08:27:43 +0000 [thread overview]
Message-ID: <1280132864-8266-1-git-send-email-segooon@gmail.com> (raw)
worker_loop() uses schedule_timeout() without setting state to
STATE_(UN)INTERRUPTIBLE. As it is called in cycle without checking of
pending signals, use schedule_timeout_uninterruptible().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
fs/btrfs/async-thread.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 7ec1409..54eb070 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -362,7 +362,7 @@ again:
* worker->working is still 1, so nobody
* is going to try and wake us up
*/
- schedule_timeout(1);
+ schedule_timeout_uninterruptible(1);
smp_mb();
if (!list_empty(&worker->pending) ||
!list_empty(&worker->prio_pending))
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Kulikov Vasiliy <segooon@gmail.com>
To: kernel-janitors@vger.kernel.org
Cc: Chris Mason <chris.mason@oracle.com>, Tejun Heo <tj@kernel.org>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] btrfs: set task state with schedule_timeout_uninterruptible()
Date: Mon, 26 Jul 2010 12:27:43 +0400 [thread overview]
Message-ID: <1280132864-8266-1-git-send-email-segooon@gmail.com> (raw)
worker_loop() uses schedule_timeout() without setting state to
STATE_(UN)INTERRUPTIBLE. As it is called in cycle without checking of
pending signals, use schedule_timeout_uninterruptible().
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
fs/btrfs/async-thread.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 7ec1409..54eb070 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -362,7 +362,7 @@ again:
* worker->working is still 1, so nobody
* is going to try and wake us up
*/
- schedule_timeout(1);
+ schedule_timeout_uninterruptible(1);
smp_mb();
if (!list_empty(&worker->pending) ||
!list_empty(&worker->prio_pending))
--
1.7.0.4
next reply other threads:[~2010-07-26 8:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 8:27 Kulikov Vasiliy [this message]
2010-07-26 8:27 ` [PATCH] btrfs: set task state with schedule_timeout_uninterruptible() Kulikov Vasiliy
2010-07-27 3:41 ` Miao Xie
2010-07-27 3:41 ` Miao Xie
2010-07-27 17:46 ` [PATCH v2] btrfs: set task state with Vasiliy Kulikov
2010-07-27 17:46 ` [PATCH v2] btrfs: set task state with schedule_timeout_uninterruptible() Vasiliy Kulikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280132864-8266-1-git-send-email-segooon@gmail.com \
--to=segooon@gmail.com \
--cc=chris.mason@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.