From: "Menon, Nishanth" <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@Nokia.com>,
ext Laine Walker-Avina <lwalkera@pasco.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: OMAP DSS2 coming out of OFF mode without restoring context
Date: Fri, 30 Jul 2010 11:09:27 +0000 [thread overview]
Message-ID: <1280488167.6035.5.camel@Nokia-N900> (raw)
In-Reply-To: <AANLkTimpATpjeaq5OYf_5zy-o1ho2UxppjF6+Re9QqUb@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1135 bytes --]
----- Original message -----
> Hi,
>
> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > Hi,
> >
> > I'm having a problem where the DSS driver isn't restoring the
> > framebuffer parameters after going in and out of blanking with OFF
> > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > thing. I'm using the current master branch of linux-omap.
>
> You need to fill the func pointer in the board file:
>
> static struct omap_dss_board_info xxx_dss_data = {
>Â Â Â Â Â Â Â Â .get_last_off_on_transaction_id > omap_pm_get_dev_context_loss_count,
>
none of l-o board files seem to do this. I guess
with off capable master, we need this to be
defaulted under CONFIG_PM within dss/core itself?
I mean the defaults prevent display function
at off, so why ask all boards to fill it up?
Regards,
Nishanth Menon
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±ýöÝzÿâØ^nr¡ö¦zË\x1aëh¨èÚ&£ûàz¿äz¹Þú+Ê+zf£¢·h§~Ûiÿÿïêÿêçz_è®\x0fæj:+v¨þ)ߣøm
WARNING: multiple messages have this Message-ID (diff)
From: "Menon, Nishanth" <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@Nokia.com>,
ext Laine Walker-Avina <lwalkera@pasco.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>
Subject: Re: OMAP DSS2 coming out of OFF mode without restoring context
Date: Fri, 30 Jul 2010 06:09:27 -0500 [thread overview]
Message-ID: <1280488167.6035.5.camel@Nokia-N900> (raw)
----- Original message -----
> Hi,
>
> On Thu, 2010-07-29 at 23:29 +0200, ext Laine Walker-Avina wrote:
> > Hi,
> >
> > I'm having a problem where the DSS driver isn't restoring the
> > framebuffer parameters after going in and out of blanking with OFF
> > mode enabled. The problem appears to be in dss_get_ctx_id() in that
> > pdata->get_last_off_on_transaction_id is 0. Commenting out the call to
> > dss_need_ctx_restore() in dss_clk_enable() appears to do the right
> > thing. I'm using the current master branch of linux-omap.
>
> You need to fill the func pointer in the board file:
>
> static struct omap_dss_board_info xxx_dss_data = {
> .get_last_off_on_transaction_id =
> omap_pm_get_dev_context_loss_count,
>
none of l-o board files seem to do this. I guess
with off capable master, we need this to be
defaulted under CONFIG_PM within dss/core itself?
I mean the defaults prevent display function
at off, so why ask all boards to fill it up?
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-07-30 11:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 21:29 OMAP DSS2 coming out of OFF mode without restoring context Laine Walker-Avina
2010-07-29 21:29 ` Laine Walker-Avina
2010-07-30 6:57 ` Tomi Valkeinen
2010-07-30 6:57 ` Tomi Valkeinen
2010-07-30 11:09 ` Menon, Nishanth [this message]
2010-07-30 11:09 ` Menon, Nishanth
2010-07-30 11:17 ` Tomi Valkeinen
2010-07-30 11:17 ` Tomi Valkeinen
2010-07-30 13:01 ` Nishanth Menon
2010-07-30 13:01 ` Nishanth Menon
2010-07-30 15:15 ` Aguirre, Sergio
2010-07-30 15:15 ` Aguirre, Sergio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280488167.6035.5.camel@Nokia-N900 \
--to=nm@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lwalkera@pasco.com \
--cc=tomi.valkeinen@Nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.