All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF
@ 2010-08-03  3:04 Jerone Young
  2010-08-03  5:43 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Jerone Young @ 2010-08-03  3:04 UTC (permalink / raw)
  To: alsa-devel; +Cc: Takashi Iwai

The Lenovo X301 does not have the ability to connect to a docking
station to use the SPDIF port. It also does not have the ability to do
SPDIF though the headphone jack or Display Port jacks.

This patch fixes it so this is not exposed for the X301 and users do
think it has the ability to do SPDIF.

I tested both headphone & display port jacks and it is not there. I have
tested this patch and it works great.

Also to add the other Thinkpads have different subsystem codec IDs. 
Here are examples:

X301:
http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt

X200:
http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt

W500:
http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt


Signed-off-by: Jerone Young <jerone.young@canonical.com>

@@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec)
 		break;
 	case CXT5051_LENOVO_X200:
 		spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
+		/* Thinkpad X301 does not have S/PDIF wired and no ability
+		   to use a docking station. */
+		if (codec->subsystem_id == 0x17aa211f) {
+			spec->multiout.dig_out_nid = 0; 
+		}
 		break;
 	case CXT5051_F700:
 		spec->init_verbs[0] = cxt5051_f700_init_verbs;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF
  2010-08-03  3:04 [PATCH] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF Jerone Young
@ 2010-08-03  5:43 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2010-08-03  5:43 UTC (permalink / raw)
  To: Jerone Young; +Cc: alsa-devel

At Mon, 02 Aug 2010 22:04:13 -0500,
Jerone Young wrote:
> 
> The Lenovo X301 does not have the ability to connect to a docking
> station to use the SPDIF port. It also does not have the ability to do
> SPDIF though the headphone jack or Display Port jacks.
> 
> This patch fixes it so this is not exposed for the X301 and users do
> think it has the ability to do SPDIF.
> 
> I tested both headphone & display port jacks and it is not there. I have
> tested this patch and it works great.
> 
> Also to add the other Thinkpads have different subsystem codec IDs. 
> Here are examples:
> 
> X301:
> http://launchpadlibrarian.net/31561902/Card0.Codecs.codec.0.txt
> 
> X200:
> http://launchpadlibrarian.net/49055036/Card0.Codecs.codec.0.txt
> 
> W500:
> http://launchpadlibrarian.net/36276057/Card0.Codecs.codec.0.txt
> 
> 
> Signed-off-by: Jerone Young <jerone.young@canonical.com>

The patch format is broken.  Could you resend with the right one?


thanks,

Takashi

> 
> @@ -2004,6 +2006,11 @@ static int patch_cxt5051(struct hda_codec *codec)
>  		break;
>  	case CXT5051_LENOVO_X200:
>  		spec->init_verbs[0] = cxt5051_lenovo_x200_init_verbs;
> +		/* Thinkpad X301 does not have S/PDIF wired and no ability
> +		   to use a docking station. */
> +		if (codec->subsystem_id == 0x17aa211f) {
> +			spec->multiout.dig_out_nid = 0; 
> +		}
>  		break;
>  	case CXT5051_F700:
>  		spec->init_verbs[0] = cxt5051_f700_init_verbs;
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-03  5:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03  3:04 [PATCH] FIX to not expose SPDIF on Thinkpad X301, since it does not have the ability to use SPDIF Jerone Young
2010-08-03  5:43 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.