All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] V4L/DVB: ir-code: Add missing "select BITREVERSE"
@ 2010-08-03 18:18 H. Peter Anvin
  2010-08-03 18:28 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: H. Peter Anvin @ 2010-08-03 18:18 UTC (permalink / raw)
  To: Mauro Carvalho Chehab
  Cc: linux-media, hpa, H. Peter Anvin, David Härdeman,
	Mauro Carvalho Chehab

The Sony and JVC IR drivers use bitreverse but don't properly encode
the dependency.

Found by randconfig builds.

Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: David Härdeman <david@hardeman.nu>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
---
 drivers/media/IR/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig
index d22a8ec..6cd93b4 100644
--- a/drivers/media/IR/Kconfig
+++ b/drivers/media/IR/Kconfig
@@ -42,6 +42,7 @@ config IR_RC6_DECODER
 config IR_JVC_DECODER
 	tristate "Enable IR raw decoder for the JVC protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---
@@ -51,6 +52,7 @@ config IR_JVC_DECODER
 config IR_SONY_DECODER
 	tristate "Enable IR raw decoder for the Sony protocol"
 	depends on IR_CORE
+	select BITREVERSE
 	default y
 
 	---help---
-- 
1.7.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] V4L/DVB: ir-code: Add missing "select BITREVERSE"
  2010-08-03 18:18 [PATCH] V4L/DVB: ir-code: Add missing "select BITREVERSE" H. Peter Anvin
@ 2010-08-03 18:28 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2010-08-03 18:28 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Mauro Carvalho Chehab, linux-media, hpa, David Härdeman,
	Mauro Carvalho Chehab

On Tue,  3 Aug 2010 11:18:28 -0700 H. Peter Anvin wrote:

> The Sony and JVC IR drivers use bitreverse but don't properly encode
> the dependency.
> 
> Found by randconfig builds.

Hi,

These are already merged into linux-next... and Mauro has sent a pull request
that includes these patches.


> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
> Cc: David Härdeman <david@hardeman.nu>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
>  drivers/media/IR/Kconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/IR/Kconfig b/drivers/media/IR/Kconfig
> index d22a8ec..6cd93b4 100644
> --- a/drivers/media/IR/Kconfig
> +++ b/drivers/media/IR/Kconfig
> @@ -42,6 +42,7 @@ config IR_RC6_DECODER
>  config IR_JVC_DECODER
>  	tristate "Enable IR raw decoder for the JVC protocol"
>  	depends on IR_CORE
> +	select BITREVERSE
>  	default y
>  
>  	---help---
> @@ -51,6 +52,7 @@ config IR_JVC_DECODER
>  config IR_SONY_DECODER
>  	tristate "Enable IR raw decoder for the Sony protocol"
>  	depends on IR_CORE
> +	select BITREVERSE
>  	default y
>  
>  	---help---
> -- 
> 1.7.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-03 18:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 18:18 [PATCH] V4L/DVB: ir-code: Add missing "select BITREVERSE" H. Peter Anvin
2010-08-03 18:28 ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.