All of lore.kernel.org
 help / color / mirror / Atom feed
From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: memblock_is_region_reserved() issue
Date: Wed, 04 Aug 2010 04:02:17 -0000	[thread overview]
Message-ID: <1280894327.1902.138.camel@pasglop> (raw)
In-Reply-To: <1280885890.1902.134.camel@pasglop>

Hi folks !

You seem to use memblock_is_region_reserved() in a few places in the new
code assuming (as I would) that it returns a boolean (0 reserved, !0 not
reserved).

However, the implementation looks totally wrong. I was wondering if you
had noticed :-)

I'm about to send a fix, but wanted to make sure you guys were ok with
it.

Cheers,
Ben.

  reply	other threads:[~2010-08-04  4:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-04  0:38 memblock glitch Benjamin Herrenschmidt
2010-08-04  1:38 ` Benjamin Herrenschmidt
2010-08-04  4:02   ` Benjamin Herrenschmidt [this message]
2010-09-02 13:41     ` memblock_is_region_reserved() issue Russell King - ARM Linux
2010-08-04  8:54   ` memblock glitch Russell King - ARM Linux
2010-08-04 10:41     ` Benjamin Herrenschmidt
2010-08-04  8:49 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1280894327.1902.138.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.