From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
To: linux-arm-kernel@lists.infradead.org
Subject: memblock glitch
Date: Wed, 04 Aug 2010 20:41:04 +1000 [thread overview]
Message-ID: <1280918464.1902.148.camel@pasglop> (raw)
In-Reply-To: <20100804085447.GB4927@n2100.arm.linux.org.uk>
On Wed, 2010-08-04 at 09:54 +0100, Russell King - ARM Linux wrote:
>
> You could do, but do we want to introduce size checks for pfn_valid?
> I'm slightly concerned because it can be a hot path.
>
> If all entries in memblock are already page aligned, if addr falls
> within a memblock, it must cover the entire page so checking the size
> seems redundant for this case.
Ok, I've done a separate function for single address and range for now.
Feel free to look at my memblock branch in powerpc.git.
I'm still thinking however whether I should just expose a
memblock_pfn_valid() that can be directly hooked up to arch that wants
it to limit the overhead to a minimum..
Cheers,
Ben.
next prev parent reply other threads:[~2010-08-04 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 0:38 memblock glitch Benjamin Herrenschmidt
2010-08-04 1:38 ` Benjamin Herrenschmidt
2010-08-04 4:02 ` memblock_is_region_reserved() issue Benjamin Herrenschmidt
2010-09-02 13:41 ` Russell King - ARM Linux
2010-08-04 8:54 ` memblock glitch Russell King - ARM Linux
2010-08-04 10:41 ` Benjamin Herrenschmidt [this message]
2010-08-04 8:49 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280918464.1902.148.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.