All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev@dpdk.org, Luca Boccassi <bluca@debian.org>,
	david.marchand@redhat.com,
	 Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] doc: ensure sphinx output is reproducible
Date: Sun, 26 May 2024 13:30:36 +0200	[thread overview]
Message-ID: <12813876.VsHLxoZxqI@thomas> (raw)
In-Reply-To: <ZWTLQPFxRqAEWMw9@bricha3-MOBL.ger.corp.intel.com>

27/11/2023 18:00, Bruce Richardson:
> On Mon, Nov 27, 2023 at 05:45:52PM +0100, Thomas Monjalon wrote:
> > 06/07/2023 14:49, Christian Ehrhardt:
> > > On Mon, Jul 3, 2023 at 5:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > >
> > > > 29/06/2023 14:58, christian.ehrhardt@canonical.com:
> > > > > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> > > > >
> > > > > By adding -j we build in parallel, to make building on multiprocessor
> > > > > machines more effective. While that works it does also break
> > > > > reproducible builds as the order of the sphinx generated searchindex.js
> > > > > is depending on execution speed of the individual processes.
> > > > [...]
> > > > > -if Version(ver) >= Version('1.7'):
> > > > > -    sphinx_cmd += ['-j', 'auto']
> > > >
> > > > What is the impact on build speed on an average machine?
> > > 
> > > Hi,
> > > I haven't tested this in isolation as it was just a mandatory change
> > > on the Debian/Ubuntu side.
> > > And the time for exactly and only the doc build is hidden inside the
> > > concurrency of meson.
> > > But I can compare a full build [1] and a full build with the change [2].
> > > 
> > > That is an average build machine and it is 35 seconds slower with the
> > > change to no more do doc builds in parallel.
> > 
> > I would prefer adding an option for reproducible build
> > (which is not a common requirement).
> > 
> Taking a slightly different tack, is it possible to sort the searchindex.js
> file post-build, so that even reproducible builds get the benefits of
> parallelism?

We never got a response to this question.

I apply this patch, but I'm waiting for an effort in the direction
Bruce is proposing.

I remove the line "from packaging.version import Version" which becomes useless.
Same for PIPE and STDOUT.

For now we are slowing down the build of docs because there is a strong push
for reproducibility and not enough effort for doing it efficiently.



      parent reply	other threads:[~2024-05-26 11:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 12:58 [PATCH] doc: ensure sphinx output is reproducible christian.ehrhardt
2023-06-29 13:02 ` Christian Ehrhardt
2023-07-03 15:29 ` Thomas Monjalon
2023-07-06 12:49   ` Christian Ehrhardt
2023-11-27 16:45     ` Thomas Monjalon
2023-11-27 17:00       ` Bruce Richardson
2024-05-17 11:29         ` Luca Boccassi
2024-05-19 13:54           ` Thomas Monjalon
2024-05-19 16:36             ` Luca Boccassi
2024-05-19 17:13               ` Thomas Monjalon
2024-05-19 17:23                 ` Luca Boccassi
2024-05-19 21:10                   ` Thomas Monjalon
2024-05-20  9:53                     ` Luca Boccassi
2024-05-20 15:39                       ` Stephen Hemminger
2024-05-20 18:59                         ` Thomas Monjalon
2024-05-26 11:30         ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12813876.VsHLxoZxqI@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.