From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: [REVISED PULL REQUEST] md updates for 2.6.36
Date: Wed, 11 Aug 2010 00:23:31 +0100 [thread overview]
Message-ID: <1281482611.5887.38.camel@localhost> (raw)
In-Reply-To: <AANLkTinbCHAB3tPos1sp078maWaHAQbRM8oWMOiF1U8D@mail.gmail.com>
On Tue, 2010-08-10 at 15:47 -0700, Linus Torvalds wrote:
>
> Hmm. Why "lib/raid6/raid6sse2.c" and friends? Why "raid6" twice? You
> don't mean "raid6+1" (mirrored raid6 ;), so why not just remove the
> second "raid6", and call it "lib/raid6/sse2.c"
>
> But I pulled. Just in case there was some logic to the duplication.
No particular reason -- I just wanted the initial move to be as simple
as possible. Since it all gets built into raid6_pq.ko and we never see
these filenames even in module names, it does make sense to rename them.
If Neil approves, git://git.infradead.org/~dwmw2/libraid-2.6.git
The userspace test/ (neé raid6test/) directory doesn't build, but it
didn't before. At least I fixed the awk incantations.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Neil Brown <neilb@suse.de>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@redhat.com
Subject: Re: [REVISED PULL REQUEST] md updates for 2.6.36
Date: Wed, 11 Aug 2010 00:23:31 +0100 [thread overview]
Message-ID: <1281482611.5887.38.camel@localhost> (raw)
In-Reply-To: <AANLkTinbCHAB3tPos1sp078maWaHAQbRM8oWMOiF1U8D@mail.gmail.com>
On Tue, 2010-08-10 at 15:47 -0700, Linus Torvalds wrote:
>
> Hmm. Why "lib/raid6/raid6sse2.c" and friends? Why "raid6" twice? You
> don't mean "raid6+1" (mirrored raid6 ;), so why not just remove the
> second "raid6", and call it "lib/raid6/sse2.c"
>
> But I pulled. Just in case there was some logic to the duplication.
No particular reason -- I just wanted the initial move to be as simple
as possible. Since it all gets built into raid6_pq.ko and we never see
these filenames even in module names, it does make sense to rename them.
If Neil approves, git://git.infradead.org/~dwmw2/libraid-2.6.git
The userspace test/ (neé raid6test/) directory doesn't build, but it
didn't before. At least I fixed the awk incantations.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-08-10 23:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-10 0:14 [REVISED PULL REQUEST] md updates for 2.6.36 Neil Brown
2010-08-10 0:14 ` Neil Brown
2010-08-10 22:47 ` Linus Torvalds
2010-08-10 22:47 ` Linus Torvalds
2010-08-10 23:23 ` David Woodhouse [this message]
2010-08-10 23:23 ` David Woodhouse
2010-08-11 20:49 ` Neil Brown
2010-08-11 20:49 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281482611.5887.38.camel@localhost \
--to=dwmw2@infradead.org \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.